Review TYPO3_8-7 Merged

59524[SECURITY] Raise bootstrap 3.4.0 to fix XSS in JS components

Oliver Hader CR +2 V +2 Easy +9 −38 updated 01/22/19, 08:41

Commit message

Fixes an XSS issue in Alert, Carousel, Collapse, Dropdown, Modal,
and Tab components.

Executed tasks:
  cd Build
  yarn add bootstrap-sass@^3.4.0 --dev
  yarn exec grunt

Then copying the contents of Build/node_modules/bootstrap-sass/assets/javascripts/bootstrap.min.js
into typo3/sysext/core/Resources/Public/JavaScript/Contrib/bootstrap/bootstrap.js
additionally adding the AMD factory wrapper.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2

Issues 1

Files 5

Review log 3

  1. Oliver Hader uploaded patch set 1 01/22/19, 08:41

  2. Oliver Hader commented on patch set 1 V +2 CR +2 01/22/19, 08:41

    Auto-approved
  3. Oliver Hader merged patch set 2 01/22/19, 08:41