Review TYPO3_8-7 Merged

59525[SECURITY] Use a fluid template for the ConfirmationFinisher message

Oliver Hader CR +2 V +2 Normal +213 −7 updated 01/22/19, 09:23

Commit message

The ConfirmationFinisher message is now rendered within a fluid template
to allow styling of the message.
Furthermore, the FormRuntime (and thus all form element values) and the
finisherVariableProvider are available in the template.
Custom variables can be added globally within the form setup or at
form level in the form definition.
By using a fluid template and the associated html escaping, the display
of the ConfirmationFinisher message is protected against XSS / html
injection attacks.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2

Issues 1

Files 6

Review log 34

  1. Oliver Hader uploaded patch set 1 01/22/19, 08:41

  2. Oliver Hader commented on patch set 1 V +2 CR +2 01/22/19, 08:41

    Auto-approved
  3. Oliver Hader merged patch set 2 01/22/19, 08:41

  4. TYPO3com voted on patch set 1 V +1 01/22/19, 09:23 Completed build in 35m 54s on Tue, 22 Jan, 10:23 AM Test Summary: 79478 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3381