Review main Merged

59541[TASK] Use PSR-15 middlewares in install tool

Benjamin Franzke CR +2 V +2 Hard +122 −208 updated 01/28/19, 19:44

Commit message

Remove the old concept of priority-based HTTP request handlers,
and use statically configured PSR-15 middlewares instead.
Tranform the priority based request handlers into a set of
chained middlewares.

In case none of the middlewares handles the request a
NotFoundRequestHandler returns a 404 response
(replacing the previous exception that was thrown in that case).
This scheme of using a 404 handler as "last" request handler is
not new, it is also used in zend expressive (a PSR-15 framework).

The TYPO3 RequestHandlerInterface is marked @internal and was set
to be removed in v9, therefore we drop it now and also remove its
implementation from the frontend and backend request handlers.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 813

  1. Benjamin Franzke uploaded patch set 1 01/22/19, 08:47

  2. Benjamin Franzke uploaded patch set 2 01/22/19, 09:04

  3. TYPO3com voted on patch set 1 V +1 01/22/19, 09:43 Completed build in 53m 41s on Tue, 22 Jan, 10:43 AM Test Summary: 46910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31718

  4. TYPO3com voted on patch set 2 V +1 01/22/19, 09:49 Completed build in 12m 22s on Tue, 22 Jan, 10:49 AM Test Summary: 46910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31719

  5. Benjamin Franzke updated the commit message in patch set 3 01/22/19, 10:05

  6. TYPO3com voted on patch set 3 V +1 01/22/19, 10:18 Completed build in 12m 30s on Tue, 22 Jan, 11:18 AM Test Summary: 46910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31720

  7. Benjamin Franzke uploaded patch set 4 01/22/19, 13:47

  8. TYPO3com voted on patch set 4 V +1 01/22/19, 13:58 Completed build in 10m 58s on Tue, 22 Jan, 02:58 PM Test Summary: 46910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31722

  9. Benjamin Franzke uploaded patch set 5 01/28/19, 14:38

  10. TYPO3com voted on patch set 5 V +1 01/28/19, 14:50 Completed build in 12m 29s on Mon, 28 Jan, 03:50 PM Test Summary: 46898 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31789

  11. Benni Mack voted on patch set 5 V +1 CR +1 01/28/19, 19:40

  12. Georg Ringer voted on patch set 5 V +2 CR +2 01/28/19, 19:44

  13. Georg Ringer merged patch set 6 01/28/19, 19:44