Review TYPO3_8-7 Merged

59548[BUGFIX] Use Json-based response for RequireJsController

Benni Mack CR +2 V +2 Easy +23 −3 updated 01/22/19, 15:11

Commit message

This is a regression due to a very unfortunate
rebasing of a security backport which had the
exact code as changed here in the original change
which was tested.

The main reason is that JsonResponse is only
available in v9 or later.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Mathias Brodala +1
    • Susi Moog +1
  • Verified V +2
    • Oliver Hader +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2326

Show 1 earlier messages
  1. Benni Mack uploaded patch set 1 01/22/19, 12:18

  1. Achim Fritz voted on patch set 1 CR +1 01/22/19, 12:26

  2. Mathias Brodala commented on patch set 1 CR +1 01/22/19, 12:32

    RequireJsController.php:122

    Micro nitpick: the original JsonResponse does not write its payload to the body if it is empty. But in this case it probably doesn't matter.
  3. Susi Moog voted on patch set 1 V +1 CR +1 01/22/19, 12:35

  4. TYPO3com voted on patch set 1 V +1 01/22/19, 12:35 Completed build in 17m 03s on Tue, 22 Jan, 01:35 PM Test Summary: 79510 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3388

  5. Benni Mack commented on patch set 1 01/22/19, 12:55

    RequireJsController.php:122 Reply

    yeah, I'd rather wonder if "null" gets in, that this returns proper things in "json_encode()".
  6. Susi Moog commented on patch set 1 01/22/19, 12:59

    RequireJsController.php:122 Reply

    it returns string(4) "null" - I guess we could also add the if around it to be sure.
  7. Benni Mack commented on patch set 2 01/22/19, 13:02

    Published edit on patch set 1.
  8. Oliver Hader voted on patch set 2 CR +1 01/22/19, 13:06

  9. TYPO3com voted on patch set 2 V +1 01/22/19, 13:26 Completed build in 24m 30s on Tue, 22 Jan, 02:26 PM Test Summary: 79510 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3389

  10. Susi Moog voted on patch set 2 V +1 CR +1 01/22/19, 13:29

  11. Oliver Hader voted on patch set 2 V +1 01/22/19, 13:32

  12. Mathias Brodala commented on patch set 2 01/22/19, 13:34

    RequireJsController.php:122

    This means that empt-ish values are converted to null. Wasn't the suggestion of Susi to avoid this?
  13. Oliver Hader commented on patch set 2 CR 0 01/22/19, 13:37

    RequireJsController.php:122 Reply

    Default is empty array
  14. Oliver Hader voted on patch set 2 CR +1 01/22/19, 13:41

  15. Oliver Hader commented on patch set 2 01/22/19, 13:43

    RequireJsController.php:122 Reply

    "correct" probably would be to send empty response in case $configuration is empty
  16. Susi Moog commented on patch set 2 01/22/19, 14:05

    RequireJsController.php:122 Reply

    My original suggestion was to do the write() only when configuration is non-empty. it doesn't matter much, as the patch "works" - but would probably be more formally correct.
  17. Mathias Brodala commented on patch set 3 01/22/19, 14:17

    Published edit on patch set 2.
  18. Mathias Brodala commented on patch set 3 01/22/19, 14:17

    Adjusted for 1:1 functionality, please revote.
  19. Mathias Brodala voted on patch set 3 CR +1 01/22/19, 14:17

  20. Oliver Hader voted on patch set 3 V +1 CR +1 01/22/19, 14:20

  21. Susi Moog voted on patch set 3 CR +1 01/22/19, 14:35

  22. Susi Moog voted on patch set 3 V +1 01/22/19, 14:36

  23. TYPO3com voted on patch set 3 V +1 01/22/19, 14:43 Completed build in 25m 04s on Tue, 22 Jan, 03:43 PM Test Summary: 79510 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3391

  24. Oliver Hader voted on patch set 3 V +2 CR +2 01/22/19, 15:10

  25. Oliver Hader merged patch set 4 01/22/19, 15:11