59548[BUGFIX] Use Json-based response for RequireJsController
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Mathias Brodala +1
- Susi Moog +1
-
Verified V +2
- Oliver Hader +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 2326
Show 1 earlier messages
-
Benni Mack uploaded patch set 1 01/22/19, 12:18
-
Achim Fritz voted on patch set 1 CR +1 01/22/19, 12:26
-
Mathias Brodala commented on patch set 1 CR +1 01/22/19, 12:32
-
Susi Moog voted on patch set 1 V +1 CR +1 01/22/19, 12:35
-
TYPO3com voted on patch set 1 V +1 01/22/19, 12:35 Completed build in 17m 03s on Tue, 22 Jan, 01:35 PM Test Summary: 79510 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3388
-
Benni Mack commented on patch set 1 01/22/19, 12:55
RequireJsController.php:122Replyyeah, I'd rather wonder if "null" gets in, that this returns proper things in "json_encode()". -
Susi Moog commented on patch set 1 01/22/19, 12:59
RequireJsController.php:122Replyit returns string(4) "null" - I guess we could also add the if around it to be sure. -
Benni Mack commented on patch set 2 01/22/19, 13:02
Published edit on patch set 1. -
Oliver Hader voted on patch set 2 CR +1 01/22/19, 13:06
-
TYPO3com voted on patch set 2 V +1 01/22/19, 13:26 Completed build in 24m 30s on Tue, 22 Jan, 02:26 PM Test Summary: 79510 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3389
-
Susi Moog voted on patch set 2 V +1 CR +1 01/22/19, 13:29
-
Oliver Hader voted on patch set 2 V +1 01/22/19, 13:32
-
Mathias Brodala commented on patch set 2 01/22/19, 13:34
RequireJsController.php:122This means that empt-ish values are converted to null. Wasn't the suggestion of Susi to avoid this? -
Oliver Hader commented on patch set 2 CR 0 01/22/19, 13:37
RequireJsController.php:122ReplyDefault is empty array -
Oliver Hader voted on patch set 2 CR +1 01/22/19, 13:41
-
Oliver Hader commented on patch set 2 01/22/19, 13:43
RequireJsController.php:122Reply"correct" probably would be to send empty response in case $configuration is empty -
Susi Moog commented on patch set 2 01/22/19, 14:05
RequireJsController.php:122ReplyMy original suggestion was to do the write() only when configuration is non-empty. it doesn't matter much, as the patch "works" - but would probably be more formally correct. -
Mathias Brodala commented on patch set 3 01/22/19, 14:17
Published edit on patch set 2. -
Mathias Brodala commented on patch set 3 01/22/19, 14:17
Adjusted for 1:1 functionality, please revote. -
Mathias Brodala voted on patch set 3 CR +1 01/22/19, 14:17
-
Oliver Hader voted on patch set 3 V +1 CR +1 01/22/19, 14:20
-
Susi Moog voted on patch set 3 CR +1 01/22/19, 14:35
-
Susi Moog voted on patch set 3 V +1 01/22/19, 14:36
-
TYPO3com voted on patch set 3 V +1 01/22/19, 14:43 Completed build in 25m 04s on Tue, 22 Jan, 03:43 PM Test Summary: 79510 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3391
-
Oliver Hader voted on patch set 3 V +2 CR +2 01/22/19, 15:10
-
Oliver Hader merged patch set 4 01/22/19, 15:11
RequireJsController.php:122