59554[TASK] Update typo3fluid/fluid to 2.6.0
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Oliver Klee +1
- Jonas Eberle +1
- Andreas Kienast +1
- Mona Muzaffar +1
-
Verified V +2
- Anja Leichsenring +2
- Jonas Eberle +1
- Andreas Kienast +1
- Mona Muzaffar +1
- TYPO3com +1 CI
Issues 5
- Bug #86930ifAuthenticated ViewHelper produces no output on first run after template modification / cache clear
- Bug #86890AbstractTagBasedViewHelper recycles the TagBuilder
- Bug #87430Fields which are not required render with required attribute
- Bug #86910All text input fields get required="required" attribute
- Bug #87586ext:form field properties get inherited to subsequent fields
Files 6
Review log 2531
Show 56 earlier messages
-
Gerrit Mohrmann uploaded patch set 1 01/23/19, 20:48
-
TYPO3com voted on patch set 1 V +1 01/23/19, 20:58 Completed build in 10m 29s on Wed, 23 Jan, 09:58 PM Test Summary: 46910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31739
-
Benni Mack voted on patch set 1 CR +1 01/31/19, 09:28
-
Oliver Klee commented on patch set 1 01/31/19, 10:47
Shouldn't we also update composer.json so that this is the minimum version and we can rely on the new features being present even in Composer-based installations? -
Oliver Klee voted on patch set 1 CR -1 01/31/19, 14:57
-
Alexander Schnitzler commented on patch set 1 01/31/19, 17:00
@Oliver: I don't get it. ^2.5.2 will prefer 2.6.0 if available. That's why this patch, i.e. only a change in composer.lock, is possible in the first place. Let me ask differently. Does the core use features of 2.6.0 that break composer based installations that might still use 2.5.x after solely updating TYPO3 (without dependencies)? Then I'd say, 2.6.0 is necessary in composer.json as well. I don't know what exactly changed in 2.6.0, so I my opinion would be: Better safe than sorry and that'd be a -1 for the current version of the patch.
-
Oliver Klee commented on patch set 1 01/31/19, 17:31
According to the commit message …: Fixes missing output in ifAuthenticatedViewHelper after cache clearing. Is this incorrect? And the requirements in the composer.json must be so that the application works fine even with the lowest version of the dependencies (for example, if another package requires the lower version). -
Jonas Eberle updated the commit message in patch set 2 02/01/19, 10:19
-
Jonas Eberle commented on patch set 2 CR -1 02/01/19, 10:25
I am also for changing composer.json to ^2.6.0 because we want fluid bugfixes. By semantic versioning >= 2.6.0, < 3.0.0 are all backwards compatible. -
TYPO3com voted on patch set 2 V +1 02/01/19, 10:36 Completed build in 12m 36s on Fri, 1 Feb, 11:36 AM Test Summary: 46944 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31882
-
Jonas Eberle commented on patch set 2 V +1 CR +1 02/01/19, 10:54
Sorry, my last comment did not make any sense. Of course with ^2.5.2 we also get bugfixes until < 3.0.0 -
Andreas Wolf commented on patch set 2 02/01/19, 10:58
The point is still that ^2.5.2 will allow 2.5.x to be installed, so it's possible to end up without the 2.6 features (or bugfixes, in this case) -
Jonas Eberle commented on patch set 3 02/01/19, 11:43
Published edit on patch set 2. -
TYPO3com voted on patch set 3 V -1 02/01/19, 11:43 Completed build in 11s on Fri, 1 Feb, 12:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31892
-
Jonas Eberle commented on patch set 3 V +1 CR +1 02/01/19, 11:43
Absolutely, I agree -
Anja Leichsenring commented on patch set 3 CR -1 02/01/19, 11:54
why fix the version to 2.6? Something broken in 2.5? Not as far as I know, so why limit the choices? ^2.5 will allow for 2.6 to be installed, if the other dependencies allow for that. -
Anja Leichsenring commented on patch set 3 CR 0 02/01/19, 12:02
> Patch Set 3: Code-Review-1 > > why fix the version to 2.6? Something broken in 2.5? Not as far as I know, so why limit the choices? ^2.5 will allow for 2.6 to be installed, if the other dependencies allow for that. alright, sorry, ignore. I misread the issue. -
Anja Leichsenring uploaded patch set 4 02/01/19, 12:09
-
TYPO3com voted on patch set 4 V -1 02/01/19, 12:21 Completed build in 12m 35s on Fri, 1 Feb, 01:21 PM Test Summary: 46932 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31899
-
Andreas Kienast uploaded patch set 5 02/01/19, 13:04
-
TYPO3com voted on patch set 5 V +1 02/01/19, 13:16 Completed build in 11m 39s on Fri, 1 Feb, 02:16 PM Test Summary: 46932 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31907
-
Oliver Klee voted on patch set 5 CR +1 02/01/19, 13:30
-
Anja Leichsenring updated the commit message in patch set 6 02/01/19, 14:01
-
TYPO3com voted on patch set 6 V +1 02/01/19, 14:12 Completed build in 10m 59s on Fri, 1 Feb, 03:12 PM Test Summary: 46932 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31915
-
Jonas Eberle voted on patch set 6 V +1 CR +1 02/01/19, 14:13
-
Oliver Klee voted on patch set 6 CR +1 02/01/19, 14:15
-
Andreas Kienast voted on patch set 6 CR +1 02/01/19, 15:05
-
Mona Muzaffar voted on patch set 6 V +1 CR +1 02/01/19, 15:24
-
Andreas Kienast voted on patch set 6 V +1 02/01/19, 15:28
-
Anja Leichsenring voted on patch set 6 V +2 CR +2 02/01/19, 15:45
-
Anja Leichsenring merged patch set 7 02/01/19, 15:45