Review main Merged

59567[TASK] bamboo: db dependency loop needs break condition

Christian Kuhn CR +2 V +2 Normal +66 −36 updated 01/25/19, 13:21

Commit message

Functional and acceptance tests need a db up and running.
The according container is started as dependency and a
loop delays further execution until the database connected
to its network port. This sometimes goes wrong, for
instance mssql in rare conditions does not come up. This
leads to the loop running "forever", consuming the
executing bamboo agent and the job never finishs.
The patch adds an additional break condition: If db did
not connect to the port after a minute, the job now fails.

Review

  • Code review CR +2
    • Anja Leichsenring +2
  • Verified V +2
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 46

  1. Christian Kuhn uploaded patch set 1 01/25/19, 11:05

  2. Christian Kuhn uploaded patch set 2 01/25/19, 11:10

  3. TYPO3com voted on patch set 1 V -1 01/25/19, 11:17 Completed build in 12m 27s on Fri, 25 Jan, 12:17 PM Test Summary: 44335 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31759

  4. TYPO3com voted on patch set 2 V +1 01/25/19, 11:26 Completed build in 16m 00s on Fri, 25 Jan, 12:26 PM Test Summary: 46910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31761

  5. Anja Leichsenring voted on patch set 2 V +2 CR +2 01/25/19, 11:28

  6. Anja Leichsenring merged patch set 3 01/25/19, 13:21