Review main Abandoned

59576[BUGFIX] Skip non-array TYPO3_CONF_VARS

Sascha Ternes CR 0 V 0 Easy +7 −0 updated 01/29/19, 21:39

Commit message

This fixes a PHP Warning that occurs when a TYPO3_CONF_VARS entry is not an
array.

All configuration" iterates over TYPO3_CONF_VARS and treats all entries as
arrays. This leads to a PHP Warning: Invalid argument supplied for foreach().
Such non-array TYPO3_CONF_VARS are for example
$GLOBALS['TYPO3_CONF_VARS']['TYPO3_PATH_APP'] = '...' or similar that are
set up when in Composer mode.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 34

  1. Sascha Ternes uploaded patch set 1 01/28/19, 16:44

  2. TYPO3com voted on patch set 1 V -1 01/28/19, 16:45 Completed build in 07s on Mon, 28 Jan, 05:45 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31791

  3. Mathias Brodala commented on patch set 1 CR -1 01/28/19, 16:57

    We are always using TYPO3 in Composer Mode and have never seen this. In fact I just checked an instance and the "All configuration" section in the Install Tool is just fine.
  4. Sascha Ternes abandoned the change 01/29/19, 21:39

    I'm sorry to have made a mistake. In a normal Composer mode setup there are no non-array variables.