Review main Merged

59578[TASK] Use shorthand syntax for global variable $LANG consistently

Benni Mack CR +2 V +2 Hard +250 −104 updated 02/01/19, 11:22

Commit message

TYPO3 uses $GLOBALS['LANG'] directly in some places, but since
TYPO3 v7, new code started to use a short hand protected method
"getLanguageService" in order to get IDE code completion and better
analysis of code.

This patch replaces all left-over places of $GLOBALS['LANG']
and encapsulates this into a short-hand method to streamline
TYPO3 Core's code base.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Frank Nägler +1
    • Mona Muzaffar +1
  • Verified V +2
    • Andreas Wolf +2
    • Frank Nägler +1
    • Mona Muzaffar +1
    • TYPO3com +1 CI

Issues 1

Files 31

Show 11 more files

Review log 1113

  1. Benni Mack uploaded patch set 1 01/29/19, 12:42

  2. TYPO3com voted on patch set 1 V +1 01/29/19, 12:55 Completed build in 12m 38s on Tue, 29 Jan, 01:55 PM Test Summary: 46898 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31809

  3. Guido Schmechel commented on patch set 1 01/29/19, 13:01

    CachingFrameworkGarbageCollectionAdditionalFieldProvider.php:150

    Do we need the null check? So wouldn't crash the sL function if we return null?
  4. Benni Mack commented on patch set 1 01/29/19, 19:57

    CachingFrameworkGarbageCollectionAdditionalFieldProvider.php:150 Reply Unresolved

    yes. it will crash in any case :) depends on when it will crash, due to a PHP error due to strict typing or when the method is called.
  5. Frank Nägler commented on patch set 1 CR -1 01/31/19, 20:32

    on it
  6. Frank Nägler uploaded patch set 2 01/31/19, 20:45

  7. TYPO3com voted on patch set 2 V +1 01/31/19, 20:57 Completed build in 11m 36s on Thu, 31 Jan, 09:57 PM Test Summary: 46886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31868

  8. Mona Muzaffar voted on patch set 2 CR +1 02/01/19, 10:41

  9. Mona Muzaffar voted on patch set 2 V +1 02/01/19, 10:46

  10. Andreas Wolf voted on patch set 2 CR +2 02/01/19, 11:05

  11. Frank Nägler voted on patch set 2 V +1 CR +1 02/01/19, 11:14

  12. Andreas Wolf voted on patch set 2 V +2 02/01/19, 11:22

  13. Andreas Wolf merged patch set 3 02/01/19, 11:22