59578[TASK] Use shorthand syntax for global variable $LANG consistently
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
- Frank Nägler +1
- Mona Muzaffar +1
-
Verified V +2
- Andreas Wolf +2
- Frank Nägler +1
- Mona Muzaffar +1
- TYPO3com +1 CI
Issues 1
Files 31
- typo3/sysext/backend/Classes/Backend/ToolbarItems/SystemInformationToolbarItem.php+10 −1
- typo3/sysext/backend/Classes/Controller/Page/TreeController.php+11 −2
- typo3/sysext/backend/Classes/Controller/AbstractFormEngineAjaxController.php+10 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/LiveSearch.php+10 −1
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php+13 −4
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+1 −1
- typo3/sysext/core/Classes/Tree/TableConfiguration/DatabaseTreeDataProvider.php+10 −1
- typo3/sysext/felogin/Classes/Hooks/CmsLayout.php+11 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PagePathViewHelper.php+10 −1
- typo3/sysext/indexed_search/Classes/Hook/CrawlerHook.php+2 −2
- typo3/sysext/info/Classes/Controller/PageInformationController.php+11 −11
- typo3/sysext/install/Classes/Report/EnvironmentStatusReport.php+12 −3
- typo3/sysext/install/Classes/Report/SecurityStatusReport.php+21 −12
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTask.php+0 −9
- typo3/sysext/recycler/Classes/Task/CleanerTask.php+0 −8
- typo3/sysext/reports/Classes/Task/SystemStatusUpdateTask.php+0 −9
- typo3/sysext/scheduler/Classes/Example/SleepTask.php+1 −1
- typo3/sysext/scheduler/Classes/Example/SleepTaskAdditionalFieldProvider.php+10 −1
- typo3/sysext/scheduler/Classes/Example/TestTask.php+1 −1
- typo3/sysext/scheduler/Classes/Example/TestTaskAdditionalFieldProvider.php+10 −1
Show 11 more files
- typo3/sysext/scheduler/Classes/Task/AbstractTask.php+11 −2
- typo3/sysext/scheduler/Classes/Task/CachingFrameworkGarbageCollectionAdditionalFieldProvider.php2+11 −2
- typo3/sysext/scheduler/Classes/Task/ExecuteSchedulableCommandTask.php+0 −9
- typo3/sysext/scheduler/Classes/Task/IpAnonymizationTask.php+1 −1
- typo3/sysext/scheduler/Classes/Task/OptimizeDatabaseTableAdditionalFieldProvider.php+11 −2
- typo3/sysext/scheduler/Classes/Task/RecyclerGarbageCollectionAdditionalFieldProvider.php+10 −1
- typo3/sysext/scheduler/Classes/Task/TableGarbageCollectionAdditionalFieldProvider.php+10 −1
- typo3/sysext/scheduler/Classes/Task/TableGarbageCollectionTask.php+2 −2
- typo3/sysext/workspaces/Classes/Hook/BackendUtilityHook.php+10 −1
- typo3/sysext/workspaces/Classes/Service/StagesService.php+20 −11
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+10 −1
Review log 1113
-
Benni Mack uploaded patch set 1 01/29/19, 12:42
-
TYPO3com voted on patch set 1 V +1 01/29/19, 12:55 Completed build in 12m 38s on Tue, 29 Jan, 01:55 PM Test Summary: 46898 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31809
-
Guido Schmechel commented on patch set 1 01/29/19, 13:01
-
Benni Mack commented on patch set 1 01/29/19, 19:57
CachingFrameworkGarbageCollectionAdditionalFieldProvider.php:150Reply Unresolvedyes. it will crash in any case :) depends on when it will crash, due to a PHP error due to strict typing or when the method is called. -
Frank Nägler commented on patch set 1 CR -1 01/31/19, 20:32
on it -
Frank Nägler uploaded patch set 2 01/31/19, 20:45
-
TYPO3com voted on patch set 2 V +1 01/31/19, 20:57 Completed build in 11m 36s on Thu, 31 Jan, 09:57 PM Test Summary: 46886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31868
-
Mona Muzaffar voted on patch set 2 CR +1 02/01/19, 10:41
-
Mona Muzaffar voted on patch set 2 V +1 02/01/19, 10:46
-
Andreas Wolf voted on patch set 2 CR +2 02/01/19, 11:05
-
Frank Nägler voted on patch set 2 V +1 CR +1 02/01/19, 11:14
-
Andreas Wolf voted on patch set 2 V +2 02/01/19, 11:22
-
Andreas Wolf merged patch set 3 02/01/19, 11:22
CachingFrameworkGarbageCollectionAdditionalFieldProvider.php:150