Review main Merged

59581[TASK] Increase field name of table sys_file_storage

Georg Ringer CR +2 V +2 Easy +3 −2 updated 01/30/19, 10:35

Commit message

Increase the length of the field from 30 to 255 chars to be in
sync with other tables, e.g. sys_file_mounts. 30 is fairly short
for bigger sites and lots of storages.

As this is an admin only field and not too often used, it is ok to backport
that to 9.5 as well.

Review

  • Code review CR +2
    • Markus Klein +2
    • Benni Mack +1
  • Verified V +2
    • Markus Klein +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 67

  1. Georg Ringer uploaded patch set 1 01/30/19, 07:15

  2. Benni Mack commented on patch set 1 CR +1 01/30/19, 07:16

    full ack.
  3. TYPO3com voted on patch set 1 V +1 01/30/19, 07:24 Completed build in 09m 23s on Wed, 30 Jan, 08:24 AM Test Summary: 46898 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31821

  4. Benni Mack voted on patch set 1 V +1 01/30/19, 08:09

  5. Markus Klein voted on patch set 1 V +2 CR +2 01/30/19, 10:34

  6. Markus Klein merged patch set 2 01/30/19, 10:34

  7. Markus Klein commented on patch set 2 01/30/19, 10:35

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit aea119285548c15bc8d7de1c690475f0723a8c46