Review main Merged

59583[TASK] Replace ModuleLinkViewHelper of EXT:scheduler with ModuleLinkViewHelper of EXT:backend

Georg Ringer CR +2 V +2 Normal +4 −65 updated 02/01/19, 11:30

Commit message

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Josef Glatz +1
    • Markus Klein +1
    • Fabien Udriot +1
  • Verified V +2
    • Andreas Wolf +2
    • Josef Glatz +1
    • Fabien Udriot +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1011

  1. Georg Ringer uploaded patch set 1 01/30/19, 08:25

  2. TYPO3com voted on patch set 1 V +1 01/30/19, 08:36 Completed build in 10m 34s on Wed, 30 Jan, 09:36 AM Test Summary: 46898 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31823

  3. Markus Klein commented on patch set 1 CR -1 01/30/19, 09:02

    imo scheduler needs a dependency on ext:backend then in composer json
  4. Josef Glatz commented on patch set 1 01/30/19, 09:56

    > imo scheduler needs a dependency on ext:backend then in composer > json Are you sure Markus? Since ext:backend has extra.typo3/cms.Package.partOfMinimalUsableSystem = true such a dependency isn't really necessary
  5. Markus Klein commented on patch set 1 01/30/19, 12:18

    Yes that's the current state! But who knows about the future? Nevertheless, we introduce a dependency, so write it down.
  6. Benni Mack commented on patch set 1 01/30/19, 12:47

    Markus, instead of doing this in this patch, we need to sort out dependencies properly. AFAIK Frank started doing this before 9 LTS, and frankly - it was a messy part. Core depends on Frontend and vice-versa.
  7. Markus Klein commented on patch set 1 CR +1 01/30/19, 14:37

    Alright, fine with me then.
  8. Fabien Udriot voted on patch set 1 V +1 CR +1 01/31/19, 10:06

  9. Josef Glatz voted on patch set 1 V +1 CR +1 01/31/19, 10:13

  10. Andreas Wolf voted on patch set 1 V +2 CR +2 02/01/19, 11:30

  11. Andreas Wolf merged patch set 2 02/01/19, 11:30