Review 9.5 Merged

59585[BUGFIX] Reintroduce removed page tree TSconfig settings

Soren Malling CR +2 V +2 Normal +101 −4 updated 03/04/19, 19:37

Commit message

This patch reintroduces to `excludeDoktypes` to the
pagetree ajax controller

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 1419

  1. Soren Malling uploaded patch set 1 01/30/19, 08:57

  2. TYPO3com voted on patch set 1 V -1 01/30/19, 08:59 Completed build in 21s on Wed, 30 Jan, 09:59 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-184

  3. Soren Malling commented on patch set 1 01/30/19, 09:00

    Cherry Picked This patchset was cherry picked to branch master as commit 223a6d95f837c5817fb5ba12420599bb9a3a0b3d
  4. Soren Malling uploaded patch set 2 01/30/19, 09:38

  5. TYPO3com voted on patch set 2 V +1 01/30/19, 09:50 Completed build in 11m 53s on Wed, 30 Jan, 10:50 AM Test Summary: 49077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-185

  6. Soren Malling uploaded patch set 3 02/25/19, 15:08

  7. TYPO3com voted on patch set 3 V -1 02/25/19, 15:09 Completed build in 15s on Mon, 25 Feb, 04:09 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-281

  8. Soren Malling commented on patch set 3 02/25/19, 16:33

    Please ignore the CGL warning for now - I will of course fix that before pushing for a final merge
  9. Soren Malling uploaded patch set 4 03/03/19, 07:03

  10. Soren Malling commented on patch set 4 03/03/19, 07:05

    fixed CGL issue, updated commit message and correctly applied new restrictions to the QueryBuilder
  11. TYPO3com voted on patch set 4 V +1 03/03/19, 07:15 Completed build in 12m 37s on Sun, 3 Mar, 08:15 AM Test Summary: 49333 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-312

  12. Soren Malling voted on patch set 4 V +1 03/03/19, 09:29

  13. Frank Nägler commented on patch set 4 V +1 CR -1 03/03/19, 20:08

    I can confirm it works in v9, but please check my remarks? I don't know why we have to remove the keys, please explain.

    TreeController.php:294

    why this is removed?

    PageTreeRepository.php:51

    why this is removed?

    PageTreeRepository.php:61

    why this is removed?
  14. Andreas Kienast commented on patch set 4 03/04/19, 16:21

    TreeController.php:294 Reply

    This field has been removed in v10, but is still present in v9, thus the removal is wrong on the backport.
  15. Frank Nägler uploaded patch set 5 03/04/19, 16:31

  16. Frank Nägler voted on patch set 5 V +1 CR +1 03/04/19, 16:33

  17. TYPO3com voted on patch set 5 V +1 03/04/19, 16:45 Completed build in 13m 21s on Mon, 4 Mar, 05:45 PM Test Summary: 49369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-321

  18. Benni Mack voted on patch set 5 V +2 CR +2 03/04/19, 19:37

  19. Benni Mack merged patch set 6 03/04/19, 19:37