59586[BUGFIX] Reintroduce removed page tree TSconfig settings
Commit message
Review
-
Code review CR +2 Done
- Frank Nägler +2
- Guido Schmechel +1
- Richard Haeser +1
-
Verified V +2 Done
- Frank Nägler +2
- Guido Schmechel +1
- Richard Haeser +1
- Riccardo De Contardi +1
- Soren Malling +1
- TYPO3com +1 CI
Issues 2
Files 3
Review log 2631
Show 56 earlier messages
-
Soren Malling commented on patch set 1 01/30/19, 09:00
Cherry Picked from branch 9.5. -
TYPO3com voted on patch set 1 V -1 01/30/19, 09:00 Completed build in 13s on Wed, 30 Jan, 10:00 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31827
-
Guido Schmechel commented on patch set 1 01/30/19, 09:13
Can you please execute the fix commit script? https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Appendix/CglFixMyCommit.html#cgl-fix-my-commit -
Tymoteusz Motylewski commented on patch set 1 CR -1 01/30/19, 09:36
TreeController.php:378I would prefer to limit nodes on db query time instead of on php side -
Soren Malling commented on patch set 1 01/30/19, 09:41
TreeController.php:378ReplySo would I, but that will be a change to the pagetreerepository - the original patch was on database level but I can't see a way to that without introducing a more breaking fix. There is no backend user specific taken into account in the pagetreerepository. I would have preferred this to have been a regression and revert a commit - but original dataprovider is no longer existing and since this is a pagetree only thing it's isolated here -
Einar Gislason commented on patch set 1 01/30/19, 10:07
TreeController.php:378ReplyWith the amount of pages we have, we never make it past fetchAllPages in the repository. We probably need to limit by doktype, already when building the query. We'll keep testing though
-
Soren Malling commented on patch set 1 01/30/19, 12:10
If I can be given a yes or thumbs up for introducing user tsconfig directly in the pagetreerepository or any other solution so we can bring it to the query I will provide a new patch :) I just need to be sure, that this will go into the 9 branch, since I need it for a own project self -
Tymoteusz Motylewski commented on patch set 1 01/31/19, 12:27
TreeController.php:378ReplyThe correct place to limit query and solve the mentioned issue is in the repository. This would however require to be able to pass additional config to the repository. I think we should not make repository read user TS, but it should get param form here. -
Richard Haeser commented on patch set 1 02/01/19, 08:50
+1 for the idea to reintroduce this! -
Soren Malling uploaded patch set 2 02/25/19, 15:04
-
TYPO3com voted on patch set 2 V -1 02/25/19, 15:04 Completed build in 10s on Mon, 25 Feb, 04:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32393
-
Soren Malling commented on patch set 2 02/25/19, 16:33
Please ignore the CGL warning for now - I will of course fix that before pushing for a final merge -
Frank Nägler uploaded patch set 3 03/02/19, 21:34
-
TYPO3com voted on patch set 3 V +1 03/02/19, 21:49 Completed build in 14m 10s on Sat, 2 Mar, 10:49 PM Test Summary: 46641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32484
-
Frank Nägler updated the commit message in patch set 4 03/02/19, 23:00
-
Frank Nägler commented on patch set 4 V -1 03/02/19, 23:04
the patch not work yet because the additionalQueryRestrictions are never apllied to any query.PageTreeRepository.php:108Unresolvedthis additionalQueryRestrictions are never applied in any query -
TYPO3com voted on patch set 4 V +1 03/02/19, 23:13 Completed build in 12m 50s on Sun, 3 Mar, 12:13 AM Test Summary: 46641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32486
-
Soren Malling uploaded patch set 5 03/03/19, 07:04
-
Soren Malling commented on patch set 5 03/03/19, 07:05
fixed CGL issue, updated commit message and correctly applied new restrictions to the QueryBuilder -
TYPO3com voted on patch set 5 V +1 03/03/19, 07:18 Completed build in 13m 46s on Sun, 3 Mar, 08:18 AM Test Summary: 46641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32488
-
Riccardo De Contardi commented on patch set 5 V +1 03/03/19, 09:16
verified on a clean master installation with the following setup: 1) create a home page, and under it a subpage and a sysfolder 2) create a usergroup "editors"; give all grants on tables (ACL); startingpoint: home page; 3) set all pages as group "editors", give all privileges. 4) create a non-admin user "editor"; group: editors 5) switch to editor => the sysfolder is visible in pagetree 6) in User TSconfig field of editor write "options.pageTree.excludeDoktypes = 254" 7) switch again to editor => the sysfolder is not visible -
Soren Malling voted on patch set 5 V +1 03/03/19, 09:28
-
Guido Schmechel commented on patch set 5 V -1 CR +1 03/03/19, 10:44
It basically runs as expected in the PageTree. Review was executed as described by Riccardo. All good and thanks for the description! My question: I do not have the SysFolders in the PageTree (target of the patch) but can find them in LiveSearch. Probably there is no dependency, until the clarification therefore first -1 of me. -
Soren Malling commented on patch set 5 03/03/19, 11:12
There is no connection to live search and wasn’t either in original implementation so that behavior is intended. This is purely focused on the page tree > Patch Set 5: Verified-1 Code-Review+1 > > It basically runs as expected in the PageTree. Review was executed as described by Riccardo. All good and thanks for the description! > > My question: I do not have the SysFolders in the PageTree (target of the patch) but can find them in LiveSearch. Probably there is no dependency, until the clarification therefore first -1 of me. -
Guido Schmechel commented on patch set 5 V +1 03/03/19, 11:25
Thanks for clarification :-) -
Richard Haeser voted on patch set 5 V +1 CR +1 03/03/19, 14:15
-
Frank Nägler voted on patch set 5 V +2 CR +2 03/03/19, 19:56
-
Frank Nägler merged patch set 6 03/03/19, 19:56
-
Tymoteusz Motylewski commented on patch set 6 03/03/19, 22:37
Im pretty sure there is an rst file saying this setting is removed. We should fix that rst file (and maybe also check if its mentioned in „whats new slides”) -
Riccardo De Contardi commented on patch set 6 03/04/19, 08:14
should be https://docs.typo3.org/typo3cms/extensions/core/Changelog/9.0/Breaking-82919-RemovedPageTreeRelatesTsConfigSettings.html what's new slides of version 9.0 does not seem to contain this change, just a link to the documentation (slide 59) -
Benni Mack commented on patch set 6 03/16/19, 19:44
DocumentTypeExclusionRestriction.php:36Unresolvedsuperfluous (int), as this is all strict typed.DocumentTypeExclusionRestriction.php:55Unresolvedwould have been more useful if we use "notIn()" and use just one query...