Review main Merged Breaking

59588[!!!][TASK] Remove obsolete APC Cache Backend

Josef Glatz CR +2 V +2 Hard +43 −597 updated 02/05/19, 18:54

Commit message

All occurrences of APC (without suffix "u") are removed from the
TYPO3 core since APC is discontinued and does not work with
PHP 7.x.

This changes does not affect the PHP OPcache related area.

Review

  • Code review CR +2
    • Benni Mack +2
    • Alexander Opitz +1
  • Verified V +2
    • Benni Mack +2
    • Alexander Opitz +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1929

Show 34 earlier messages
  1. Josef Glatz uploaded patch set 1 01/30/19, 13:37

  2. Josef Glatz commented on patch set 1 V -1 CR -1 01/30/19, 13:38

    Waiting for the review from Alexander Opitz
  3. Josef Glatz commented on patch set 1 01/30/19, 13:46

  4. TYPO3com voted on patch set 1 V +1 01/30/19, 13:47 Completed build in 10m 25s on Wed, 30 Jan, 02:47 PM Test Summary: 46898 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31832

  1. Josef Glatz uploaded patch set 2 01/30/19, 14:52

  2. Josef Glatz updated the commit message in patch set 3 01/30/19, 14:53

  3. TYPO3com voted on patch set 2 V +1 01/30/19, 15:04 Completed build in 12m 13s on Wed, 30 Jan, 04:04 PM Test Summary: 46898 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31834

  4. TYPO3com voted on patch set 3 V +1 01/30/19, 15:06 Completed build in 12m 38s on Wed, 30 Jan, 04:06 PM Test Summary: 46898 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31835

  5. Alexander Opitz commented on patch set 3 CR -1 01/30/19, 15:34

    Adding APCu as suggest in composer.json haven't todo with this cleanup task.
  6. Georg Ringer commented on patch set 3 01/30/19, 18:58

    this requirest a rst!
  7. Josef Glatz uploaded patch set 4 02/04/19, 13:14

  8. Josef Glatz rebased onto patch set 5 02/04/19, 13:14

  9. TYPO3com voted on patch set 5 V +1 02/04/19, 13:29 Completed build in 14m 48s on Mon, 4 Feb, 02:29 PM Test Summary: 46409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32013

  10. TYPO3com voted on patch set 4 V +1 02/04/19, 13:31 Completed build in 17m 25s on Mon, 4 Feb, 02:31 PM Test Summary: 46409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32012

  11. Mathias Brodala commented on patch set 5 02/04/19, 13:46

    Important-87583-RemoveObsoleteAPCCacheBackendImplementation.rst:4

    I know it wasn't working anyways but technically this is still a Breaking change, so please adjust the RST accordingly. Better be safe than sorry. ;-)
  12. Josef Glatz uploaded patch set 6 02/04/19, 16:42

  13. Josef Glatz updated the commit message in patch set 7 02/04/19, 16:43

  14. Josef Glatz uploaded patch set 8 02/04/19, 16:48

  15. TYPO3com voted on patch set 6 V -1 02/04/19, 17:00 Completed build in 17m 38s on Mon, 4 Feb, 06:00 PM Test Summary: 46409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32025

  16. TYPO3com voted on patch set 7 V -1 02/04/19, 17:00 Completed build in 16m 25s on Mon, 4 Feb, 06:00 PM Test Summary: 46409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32026

  17. TYPO3com voted on patch set 8 V -1 02/04/19, 17:08 Completed build in 18m 14s on Mon, 4 Feb, 06:08 PM Test Summary: 46409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32028

  18. Alexander Opitz commented on patch set 8 02/04/19, 17:38

    The error from bamboo master/Breaking-87583-RemoveObsoleteAPCCacheBackendImplementation.rst insert '.. index:: <at least one valid keyword and either FullyScanned, PartiallyScanned or NotScanned>' at last line of the file. I think NotScanned is correct here.
  19. Alexander Opitz commented on patch set 9 02/04/19, 17:38

    Published edit on patch set 8.
  20. TYPO3com voted on patch set 9 V +1 02/04/19, 17:52 Completed build in 13m 28s on Mon, 4 Feb, 06:52 PM Test Summary: 46409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32030

  21. Benni Mack commented on patch set 10 02/05/19, 13:48

    Published edit on patch set 9.
  22. TYPO3com voted on patch set 10 V +1 02/05/19, 14:02 Completed build in 14m 09s on Tue, 5 Feb, 03:02 PM Test Summary: 46409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32056

  23. Alexander Opitz voted on patch set 10 V +1 CR +1 02/05/19, 16:43

  24. Benni Mack voted on patch set 10 V +2 CR +2 02/05/19, 18:54

  25. Benni Mack merged patch set 11 02/05/19, 18:54