59588[!!!][TASK] Remove obsolete APC Cache Backend
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Alexander Opitz +1
-
Verified V +2
- Benni Mack +2
- Alexander Opitz +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1929
Show 34 earlier messages
-
Josef Glatz uploaded patch set 1 01/30/19, 13:37
-
Josef Glatz commented on patch set 1 V -1 CR -1 01/30/19, 13:38
Waiting for the review from Alexander Opitz -
Josef Glatz commented on patch set 1 01/30/19, 13:46
> For reference: https://review.typo3.org/#/c/47024/ -
TYPO3com voted on patch set 1 V +1 01/30/19, 13:47 Completed build in 10m 25s on Wed, 30 Jan, 02:47 PM Test Summary: 46898 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31832
-
Josef Glatz uploaded patch set 2 01/30/19, 14:52
-
Josef Glatz updated the commit message in patch set 3 01/30/19, 14:53
-
TYPO3com voted on patch set 2 V +1 01/30/19, 15:04 Completed build in 12m 13s on Wed, 30 Jan, 04:04 PM Test Summary: 46898 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31834
-
TYPO3com voted on patch set 3 V +1 01/30/19, 15:06 Completed build in 12m 38s on Wed, 30 Jan, 04:06 PM Test Summary: 46898 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31835
-
Alexander Opitz commented on patch set 3 CR -1 01/30/19, 15:34
Adding APCu as suggest in composer.json haven't todo with this cleanup task. -
Georg Ringer commented on patch set 3 01/30/19, 18:58
this requirest a rst! -
Josef Glatz uploaded patch set 4 02/04/19, 13:14
-
Josef Glatz rebased onto patch set 5 02/04/19, 13:14
-
TYPO3com voted on patch set 5 V +1 02/04/19, 13:29 Completed build in 14m 48s on Mon, 4 Feb, 02:29 PM Test Summary: 46409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32013
-
TYPO3com voted on patch set 4 V +1 02/04/19, 13:31 Completed build in 17m 25s on Mon, 4 Feb, 02:31 PM Test Summary: 46409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32012
-
Mathias Brodala commented on patch set 5 02/04/19, 13:46
Important-87583-RemoveObsoleteAPCCacheBackendImplementation.rst:4I know it wasn't working anyways but technically this is still a Breaking change, so please adjust the RST accordingly. Better be safe than sorry. ;-) -
Josef Glatz uploaded patch set 6 02/04/19, 16:42
-
Josef Glatz updated the commit message in patch set 7 02/04/19, 16:43
-
Josef Glatz uploaded patch set 8 02/04/19, 16:48
-
TYPO3com voted on patch set 6 V -1 02/04/19, 17:00 Completed build in 17m 38s on Mon, 4 Feb, 06:00 PM Test Summary: 46409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32025
-
TYPO3com voted on patch set 7 V -1 02/04/19, 17:00 Completed build in 16m 25s on Mon, 4 Feb, 06:00 PM Test Summary: 46409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32026
-
TYPO3com voted on patch set 8 V -1 02/04/19, 17:08 Completed build in 18m 14s on Mon, 4 Feb, 06:08 PM Test Summary: 46409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32028
-
Alexander Opitz commented on patch set 8 02/04/19, 17:38
The error from bamboo master/Breaking-87583-RemoveObsoleteAPCCacheBackendImplementation.rst insert '.. index:: <at least one valid keyword and either FullyScanned, PartiallyScanned or NotScanned>' at last line of the file. I think NotScanned is correct here. -
Alexander Opitz commented on patch set 9 02/04/19, 17:38
Published edit on patch set 8. -
TYPO3com voted on patch set 9 V +1 02/04/19, 17:52 Completed build in 13m 28s on Mon, 4 Feb, 06:52 PM Test Summary: 46409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32030
-
Benni Mack commented on patch set 10 02/05/19, 13:48
Published edit on patch set 9. -
TYPO3com voted on patch set 10 V +1 02/05/19, 14:02 Completed build in 14m 09s on Tue, 5 Feb, 03:02 PM Test Summary: 46409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32056
-
Alexander Opitz voted on patch set 10 V +1 CR +1 02/05/19, 16:43
-
Benni Mack voted on patch set 10 V +2 CR +2 02/05/19, 18:54
-
Benni Mack merged patch set 11 02/05/19, 18:54