Review main Merged

59603[TASK] Deprecate TypeHandlingUtility::hex2bin

Alexander Schnitzler CR +2 V +2 Easy +45 −0 updated 02/23/19, 17:04

Commit message

Method \TYPO3\CMS\Extbase\Utility\TypeHandlingUtility::hex2bin
has been deprecated. As of PHP 5.4, a native function hex2bin
exists, which should be used instead.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Susi Moog +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1518

  1. Alexander Schnitzler uploaded patch set 1 02/01/19, 12:01

  2. TYPO3com voted on patch set 1 V +1 02/01/19, 12:16 Completed build in 13m 27s on Fri, 1 Feb, 01:16 PM Test Summary: 46932 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31897

  3. Mona Muzaffar voted on patch set 1 V +1 CR +1 02/01/19, 12:37

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 02/01/19, 12:51

  5. André Buchmann voted on patch set 1 V +1 CR +1 02/01/19, 12:53

  6. Felix Döring voted on patch set 1 V +1 CR +1 02/01/19, 13:10

  7. Oliver Klee voted on patch set 1 CR +1 02/01/19, 13:30

  8. Andreas Wolf commented on patch set 1 CR -1 02/01/19, 15:14

    Code looks good, but I'm unhappy with the RST file.

    Deprecation-87613-DeprecateTYPO3CMSExtbaseUtilityTypeHandlingUtilityhex2bin.rst:18

    That E_DEPRECATION error is not necessarily fatal.
  9. Alexander Schnitzler uploaded patch set 2 02/02/19, 09:16

  10. TYPO3com voted on patch set 2 V +1 02/02/19, 09:31 Completed build in 15m 08s on Sat, 2 Feb, 10:31 AM Test Summary: 46401 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31963

  11. Alexander Schnitzler wrote 02/02/19, 09:45

    Topic set to extbase
  12. Oliver Klee voted on patch set 2 CR +1 02/02/19, 11:01

  13. Alexander Schnitzler uploaded patch set 3 02/17/19, 11:25

  14. TYPO3com voted on patch set 3 V +1 02/17/19, 11:39 Completed build in 13m 21s on Sun, 17 Feb, 12:38 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32259

  15. Oliver Klee voted on patch set 3 CR +1 02/17/19, 14:33

  16. Susi Moog voted on patch set 3 V +1 CR +1 02/17/19, 16:50

  17. Anja Leichsenring voted on patch set 3 V +2 CR +2 02/23/19, 17:04

  18. Anja Leichsenring merged patch set 4 02/23/19, 17:04