Review main Merged

59604[BUGFIX] Correctly renumber sorting values for value 0

Helmut Hummel CR +2 V +2 Normal +51 −49 updated 08/30/19, 07:13

Commit message

The called method reorders all elements not including
the given sorting number, leading to an off by one error
when the element in question has sorting number 0.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Roman Schilter +1
    • Markus Klein +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Roman Schilter +1
    • Markus Klein +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 18

Review log 1520

  1. Helmut Hummel uploaded patch set 1 02/01/19, 12:13

  2. Helmut Hummel commented on patch set 1 CR -1 02/01/19, 12:14

    This should be verified with functional test, which I don't have the time to create right now.
  3. TYPO3com voted on patch set 1 V -1 02/01/19, 12:24 Completed build in 10m 48s on Fri, 1 Feb, 01:24 PM Test Summary: 36 of 47325 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31900

  4. Helmut Hummel commented on patch set 1 02/01/19, 15:48

    uh, actually tests are failing now, so they only need to be (carefully) changed to match the correct expectation
  5. Markus Klein commented on patch set 1 04/15/19, 11:20

    DataHandler.php:6837 Unresolved

    I'd suggest making this parameter optional and if not set, we do not even apply the number restriction within the function
  6. Markus Klein uploaded patch set 2 07/23/19, 09:12

  7. TYPO3com voted on patch set 2 V -1 07/23/19, 09:24 Completed build in 12m 46s on Tue, 23 Jul, 11:24 AM Test Summary: 51 of 47519 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35286

  8. Markus Klein uploaded patch set 3 08/01/19, 09:20

  9. Markus Klein commented on patch set 3 08/01/19, 09:24

    copyPage.csv:46 Unresolved

    I'm pretty sure this ordering is actually a bug in workspaces!
  10. TYPO3com voted on patch set 3 V -1 08/01/19, 09:30 Completed build in 10m 13s on Thu, 1 Aug, 09:30 AM Test Summary: 12 of 47519 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35425

  11. Markus Klein uploaded patch set 4 08/01/19, 09:37

  12. TYPO3com voted on patch set 4 V +1 08/01/19, 09:48 Completed build in 10m 28s on Thu, 1 Aug, 09:48 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35426

  13. Roman Schilter commented on patch set 4 V +1 CR +1 08/23/19, 13:51

    Issue doesn't occur anymore (using the the steps from the bug-ticket to reproduce)
  14. Anja Leichsenring uploaded patch set 5 08/24/19, 14:57

  15. Anja Leichsenring voted on patch set 5 V +1 CR +1 08/24/19, 14:58

  16. TYPO3com voted on patch set 5 V +1 08/24/19, 15:07 Completed build in 09m 47s on Sat, 24 Aug, 03:07 PM Test Summary: 47227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35823

  17. Markus Klein voted on patch set 5 V +1 CR +1 08/24/19, 21:13

  18. Roman Schilter commented on patch set 5 V +1 CR +1 08/30/19, 05:47

    Only the commit message changed in patch set 5
  19. Daniel Goerz voted on patch set 5 V +2 CR +2 08/30/19, 07:13

  20. Daniel Goerz merged patch set 6 08/30/19, 07:13