59604[BUGFIX] Correctly renumber sorting values for value 0
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Roman Schilter +1
- Markus Klein +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Daniel Goerz +2
- Roman Schilter +1
- Markus Klein +1
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 18
- typo3/sysext/core/Classes/DataHandling/DataHandler.php1+6 −4
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/localizePageAddMonoglotHotelChildNCopyPageWSynchronization.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/localizePageNAddHotelChildWExclude.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/localizePageNAddHotelChildWSynchronization.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/localizePageNAddMonoglotHotelChildWSynchronization.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/localizeParentContentLanguageSynchronization.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/localizeParentContentChainLanguageSynchronizationSource.csv+3 −3
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseAssertions/importPagesAndRelatedTtContentWithDifferentImageToExistingData.csv+1 −1
- typo3/sysext/impexp/Tests/Functional/Fixtures/DatabaseAssertions/importPagesAndRelatedTtContentWithSameImageToExistingData.csv+1 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/moveParentContentToDifferentPageNChangeSorting.csv+7 −7
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Publish/DataSet/moveParentContentToDifferentPageNChangeSorting.csv+7 −7
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/PublishAll/DataSet/moveParentContentToDifferentPageNChangeSorting.csv+7 −7
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/copyPage.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/copyPageWHotelBeforeParentContent.csv+3 −3
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Publish/DataSet/copyPage.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Publish/DataSet/copyPageWHotelBeforeParentContent.csv+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/PublishAll/DataSet/copyPage.csv1+2 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/PublishAll/DataSet/copyPageWHotelBeforeParentContent.csv+2 −2
Review log 1520
-
Helmut Hummel uploaded patch set 1 02/01/19, 12:13
-
Helmut Hummel commented on patch set 1 CR -1 02/01/19, 12:14
This should be verified with functional test, which I don't have the time to create right now. -
TYPO3com voted on patch set 1 V -1 02/01/19, 12:24 Completed build in 10m 48s on Fri, 1 Feb, 01:24 PM Test Summary: 36 of 47325 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31900
-
Helmut Hummel commented on patch set 1 02/01/19, 15:48
uh, actually tests are failing now, so they only need to be (carefully) changed to match the correct expectation -
Markus Klein commented on patch set 1 04/15/19, 11:20
DataHandler.php:6837UnresolvedI'd suggest making this parameter optional and if not set, we do not even apply the number restriction within the function -
Markus Klein uploaded patch set 2 07/23/19, 09:12
-
TYPO3com voted on patch set 2 V -1 07/23/19, 09:24 Completed build in 12m 46s on Tue, 23 Jul, 11:24 AM Test Summary: 51 of 47519 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35286
-
Markus Klein uploaded patch set 3 08/01/19, 09:20
-
Markus Klein commented on patch set 3 08/01/19, 09:24
copyPage.csv:46UnresolvedI'm pretty sure this ordering is actually a bug in workspaces! -
TYPO3com voted on patch set 3 V -1 08/01/19, 09:30 Completed build in 10m 13s on Thu, 1 Aug, 09:30 AM Test Summary: 12 of 47519 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35425
-
Markus Klein uploaded patch set 4 08/01/19, 09:37
-
TYPO3com voted on patch set 4 V +1 08/01/19, 09:48 Completed build in 10m 28s on Thu, 1 Aug, 09:48 AM Test Summary: 47160 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35426
-
Roman Schilter commented on patch set 4 V +1 CR +1 08/23/19, 13:51
Issue doesn't occur anymore (using the the steps from the bug-ticket to reproduce) -
Anja Leichsenring uploaded patch set 5 08/24/19, 14:57
-
Anja Leichsenring voted on patch set 5 V +1 CR +1 08/24/19, 14:58
-
TYPO3com voted on patch set 5 V +1 08/24/19, 15:07 Completed build in 09m 47s on Sat, 24 Aug, 03:07 PM Test Summary: 47227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35823
-
Markus Klein voted on patch set 5 V +1 CR +1 08/24/19, 21:13
-
Roman Schilter commented on patch set 5 V +1 CR +1 08/30/19, 05:47
Only the commit message changed in patch set 5 -
Daniel Goerz voted on patch set 5 V +2 CR +2 08/30/19, 07:13
-
Daniel Goerz merged patch set 6 08/30/19, 07:13