59605[BUGFIX] Properly render hidden fields for IRRE records
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Daniel Goerz +1
- Oliver Klee +1
- Andreas Kienast +1
- Susi Moog +1
- Andreas Wolf +1
-
Verified V +2 Done
- Benni Mack +2
- Daniel Goerz +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1314
-
Helmut Hummel uploaded patch set 1 02/01/19, 12:23
-
Andreas Wolf voted on patch set 1 CR +1 02/01/19, 12:27
-
TYPO3com voted on patch set 1 V +1 02/01/19, 12:39 Completed build in 10m 41s on Fri, 1 Feb, 01:39 PM Test Summary: 46932 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31903
-
Benni Mack commented on patch set 1 V +1 CR +2 02/01/19, 12:41
ha, I remember re-adding this even in v7, but looks like the v8 rewrite kicked this out. -
Andreas Kienast voted on patch set 1 CR +1 02/01/19, 14:11
-
Andreas Kienast commented on patch set 1 02/01/19, 14:13
I can't test this on master. Is there a how-to-reproduce for EXT:styleguide? -
Susi Moog voted on patch set 1 V +1 CR +1 02/23/19, 18:29
-
Daniel Goerz commented on patch set 1 02/23/19, 20:58
I dont get how to verify this. If I set the description of sys_file_reference to renderType=hidden it is rendered as a hidden field in master and in 9.5. So I guess I am not testing the right thing here? -
Oliver Klee voted on patch set 1 CR +1 02/23/19, 22:36
-
Benni Mack commented on patch set 1 03/02/19, 09:40
Daniel, in the ticket description you see the example of tt_content being a child record, and colPos as renderType=hidden is not handled. -
Helmut Hummel commented on patch set 1 03/05/19, 15:00
@Daniel: Added instructions to reproduce: https://forge.typo3.org/issues/87614#note-2 -
Daniel Goerz commented on patch set 1 V +1 CR +1 03/05/19, 15:25
Well, thanks for spelling it out for me :) -
Benni Mack voted on patch set 1 V +2 03/07/19, 17:22
-
Benni Mack merged patch set 2 03/07/19, 17:22