Review main Merged

59606[BUGFIX] Use real finisher identifier in form element variants

Ralf Zimmermann CR +2 V +2 Easy +14 −2 updated 02/01/19, 15:53

Commit message

Use the real finisher identifiers as they are configured in the
form definition instead the finisher implementation class name.
This requires a change of the public AbstractFinisher implementation
which implements the FinisherInterface. The interface is not changed,
as this would be a breaking change. Therefore, the existence of the
new method is checked. If it does not exist in a finisher
implementation, a fallback to the previous behavior happens.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2
    • Anja Leichsenring +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 78

  1. Ralf Zimmermann uploaded patch set 1 02/01/19, 12:53

  2. TYPO3com voted on patch set 1 V +1 02/01/19, 13:02 Completed build in 09m 36s on Fri, 1 Feb, 02:02 PM Test Summary: 46932 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31905

  3. Susi Moog voted on patch set 1 CR +1 02/01/19, 14:50

  4. Susi Moog voted on patch set 1 V +1 02/01/19, 15:30

  5. Andreas Kienast voted on patch set 1 CR +1 02/01/19, 15:38

  6. Anja Leichsenring voted on patch set 1 V +2 CR +2 02/01/19, 15:53

  7. Anja Leichsenring merged patch set 2 02/01/19, 15:53

  8. Anja Leichsenring commented on patch set 2 02/01/19, 15:53

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit 0a31ff0808b5a3ec5fa167404d39d0ca06447551