Review 9.5 Merged

59609[TASK] Update typo3fluid/fluid to 2.6.0

Anja Leichsenring CR +2 V +2 Easy +13 −13 updated 02/03/19, 13:19

Commit message

Fixes missing output in ifAuthenticatedViewHelper after cache clearing
and erroneous replication of field properties to subsequent fields.

composer command used:
composer update typo3fluid/fluid

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Mona Muzaffar +1
    • Susi Moog +1
  • Verified V +2
    • Anja Leichsenring +2
    • Mona Muzaffar +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 5

Files 6

Review log 67

  1. Anja Leichsenring uploaded patch set 1 02/01/19, 15:51

  2. TYPO3com voted on patch set 1 V +1 02/01/19, 16:10 Completed build in 16m 27s on Fri, 1 Feb, 05:10 PM Test Summary: 49077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-190

  3. Mona Muzaffar voted on patch set 1 V +1 CR +1 02/01/19, 16:41

  4. Susi Moog voted on patch set 1 V +1 CR +1 02/01/19, 17:08

  5. Anja Leichsenring voted on patch set 1 V +2 CR +2 02/01/19, 17:11

  6. Anja Leichsenring merged patch set 2 02/01/19, 17:11

  7. Alexander Schnitzler commented on patch set 2 02/03/19, 13:19

    We need a follow up patch here. There are comments in the core saying that things need to be adjusted once fluid 2.6.0 is the minimum version. See https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/HiddenViewHelperTest.php#L44