59609[TASK] Update typo3fluid/fluid to 2.6.0
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Mona Muzaffar +1
- Susi Moog +1
-
Verified V +2
- Anja Leichsenring +2
- Mona Muzaffar +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 5
- Bug #86930ifAuthenticated ViewHelper produces no output on first run after template modification / cache clear
- Bug #86890AbstractTagBasedViewHelper recycles the TagBuilder
- Bug #87430Fields which are not required render with required attribute
- Bug #86910All text input fields get required="required" attribute
- Bug #87586ext:form field properties get inherited to subsequent fields
Files 6
Review log 67
-
Anja Leichsenring uploaded patch set 1 02/01/19, 15:51
-
TYPO3com voted on patch set 1 V +1 02/01/19, 16:10 Completed build in 16m 27s on Fri, 1 Feb, 05:10 PM Test Summary: 49077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-190
-
Mona Muzaffar voted on patch set 1 V +1 CR +1 02/01/19, 16:41
-
Susi Moog voted on patch set 1 V +1 CR +1 02/01/19, 17:08
-
Anja Leichsenring voted on patch set 1 V +2 CR +2 02/01/19, 17:11
-
Anja Leichsenring merged patch set 2 02/01/19, 17:11
-
Alexander Schnitzler commented on patch set 2 02/03/19, 13:19
We need a follow up patch here. There are comments in the core saying that things need to be adjusted once fluid 2.6.0 is the minimum version. See https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/HiddenViewHelperTest.php#L44