Review 9.5 Merged

59610[BUGFIX] Use real finisher identifier in form element variants

Anja Leichsenring CR +2 V +2 Easy +14 −2 updated 02/01/19, 17:06

Commit message

Use the real finisher identifiers as they are configured in the
form definition instead the finisher implementation class name.
This requires a change of the public AbstractFinisher implementation
which implements the FinisherInterface. The interface is not changed,
as this would be a breaking change. Therefore, the existence of the
new method is checked. If it does not exist in a finisher
implementation, a fallback to the previous behavior happens.

Review

  • Code review CR +2
    • Anja Leichsenring +2
  • Verified V +2
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Anja Leichsenring commented on patch set 1 02/01/19, 15:53

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 02/01/19, 16:19 Completed build in 20m 57s on Fri, 1 Feb, 05:19 PM Test Summary: 49077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-191

  3. Anja Leichsenring voted on patch set 1 V +2 CR +2 02/01/19, 17:06

  4. Anja Leichsenring merged patch set 2 02/01/19, 17:06