Review 9.5 Merged

59612[BUGFIX] Fix return type of determineSiteScript

Anja Leichsenring CR +2 V +2 Easy +11 −1 updated 02/01/19, 17:06

Commit message

substr returns a boolean instead of an empty string. A typecast fixes
this problem (See http://php.net/manual/de/function.substr.php#90369)

Review

  • Code review CR +2
    • Anja Leichsenring +2
  • Verified V +2
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Anja Leichsenring commented on patch set 1 02/01/19, 16:43

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 02/01/19, 17:00 Completed build in 16m 53s on Fri, 1 Feb, 06:00 PM Test Summary: 49081 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-193

  3. Anja Leichsenring voted on patch set 1 V +2 CR +2 02/01/19, 17:06

  4. Anja Leichsenring merged patch set 2 02/01/19, 17:06