Review main Merged Breaking

59623[!!!][TASK] Don't guess extension name by looking at controller name

Alexander Schnitzler CR +2 V +2 Normal +37 −56 updated 03/01/19, 17:48

Commit message

\TYPO3\CMS\Extbase\Mvc\Controller\AbstractController::$extensionName
had been set in the constructor by looking at the controller class
name and guessing the extension name by removing parts of the
class namespace.

Since the extension name is known when registering plugins and modules,
the extension name will no longer be guessed in the constructor but
can be fetched from the request object.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • Oliver Klee +1
    • Andreas Kienast +1
    • Jürgen Venne +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • Jürgen Venne +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1620

  1. Alexander Schnitzler uploaded patch set 1 02/02/19, 14:33

  2. Alexander Schnitzler wrote 02/02/19, 14:34

    Topic set to extbase
  3. TYPO3com voted on patch set 1 V +1 02/02/19, 14:46 Completed build in 12m 59s on Sat, 2 Feb, 03:46 PM Test Summary: 46401 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31983

  4. Alexander Schnitzler uploaded patch set 2 02/02/19, 15:13

  5. TYPO3com voted on patch set 2 V +1 02/02/19, 15:23 Completed build in 09m 56s on Sat, 2 Feb, 04:23 PM Test Summary: 46401 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31986

  6. Susi Moog voted on patch set 2 CR +1 02/23/19, 20:15

  7. Susi Moog voted on patch set 2 V +1 02/23/19, 20:17

  8. Anja Leichsenring uploaded patch set 3 02/23/19, 20:22

  9. Anja Leichsenring voted on patch set 3 V +1 CR +1 02/23/19, 20:24

  10. Anja Leichsenring uploaded patch set 4 02/23/19, 20:26

  11. Anja Leichsenring voted on patch set 4 V +1 CR +1 02/23/19, 20:32

  12. TYPO3com voted on patch set 3 V +1 02/23/19, 20:37 Completed build in 14m 39s on Sat, 23 Feb, 09:37 PM Test Summary: 46605 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32371

  13. TYPO3com voted on patch set 4 V +1 02/23/19, 20:46 Completed build in 18m 32s on Sat, 23 Feb, 09:46 PM Test Summary: 46605 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32373

  14. Daniel Goerz voted on patch set 4 V +1 CR +1 02/23/19, 22:40

  15. Daniel Goerz commented on patch set 4 02/23/19, 22:42

    (Can we find those usages with the extensionScanner?)
  16. Oliver Klee voted on patch set 4 CR +1 02/23/19, 23:02

  17. Jürgen Venne voted on patch set 4 V +1 CR +1 03/01/19, 10:35

  18. Andreas Kienast voted on patch set 4 CR +1 03/01/19, 15:12

  19. Anja Leichsenring voted on patch set 4 V +2 CR +2 03/01/19, 17:48

  20. Anja Leichsenring merged patch set 5 03/01/19, 17:48