Review main Merged

59628[BUGFIX] Do not treat all classes as entities in ClassSchema

Alexander Schnitzler CR +2 V +2 Easy +8 −2 updated 02/25/19, 09:07

Commit message

The ClassSchema class has a property $modelType which indicates
that a class is either an entity or a value object. This property
has a default value that reflected the state of an entity.

This means, that all classes, class schemata are created for are
considered entities which then leads to the execution of further
entity related analysis code, such as looking for specific doc
blocks and/or annotations.

While this isn't an issue functionality wise, it can be in the future.
Also, the superfluous cpu cycles can and should be spared.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1214

  1. Alexander Schnitzler uploaded patch set 1 02/04/19, 09:10

  2. TYPO3com voted on patch set 1 V +1 02/04/19, 09:21 Completed build in 10m 40s on Mon, 4 Feb, 10:21 AM Test Summary: 46409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32009

  3. Oliver Klee commented on patch set 1 02/04/19, 10:16

    ClassSchema.php:81

    Can we have a constant for this instead of a magic number, e.g. self::MODELTYPE_NONE?
  4. Alexander Schnitzler wrote 02/04/19, 12:05

    Topic set to extbase
  5. Alexander Schnitzler commented on patch set 1 02/07/19, 08:52

    ClassSchema.php:81 Reply

    As there are the follow-up patches regarding the bitset, I would not introduce a new constant now.
  6. Susi Moog updated the commit message in patch set 2 02/23/19, 17:26

  7. Susi Moog voted on patch set 2 CR +1 02/23/19, 17:28

  8. Susi Moog voted on patch set 2 V +1 02/23/19, 17:29

  9. TYPO3com voted on patch set 2 V +1 02/23/19, 18:13 Completed build in 29m 40s on Sat, 23 Feb, 07:13 PM Test Summary: 46597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32357

  10. Anja Leichsenring voted on patch set 2 V +2 CR +2 02/23/19, 18:24

  11. Anja Leichsenring merged patch set 3 02/23/19, 18:24

  12. Daniel Goerz commented on patch set 3 02/24/19, 10:26

  13. Anja Leichsenring wrote 02/25/19, 09:07

    Created a revert of this change as I2420f06822b66d74d32cc8c6b0aa07e4c55df682
  14. Anja Leichsenring wrote 02/25/19, 09:07

    Created a revert of this change as I2dbbfe0246814b50e5e6ad9eb1828590c6506445