Review main Merged

59642[BUGFIX] Catch orphaned language related exception

Patrick Schriner CR +2 V +2 Easy +1 −1 updated 02/20/19, 12:17

Commit message

Generating a preview link will not crash the backend when the relevant
site is missing the language information to build the proper url.

Review

  • Code review CR +2 Done
    • Markus Klein +2
    • Guido Schmechel +1
    • deleted-gerrit-51883 +1
  • Verified V +2 Done
    • Markus Klein +2
    • Guido Schmechel +1
    • deleted-gerrit-51883 +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Patrick Schriner uploaded patch set 1 02/05/19, 12:07

  2. TYPO3com voted on patch set 1 V +1 02/05/19, 12:24 Completed build in 16m 27s on Tue, 5 Feb, 01:24 PM Test Summary: 46409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32046

  3. Guido Schmechel commented on patch set 1 V +1 CR -1 02/07/19, 20:28

    Good catch. I would prefer to use the use statement like the other Exceptions. But basically the patch works
  4. Patrick Schriner commented on patch set 1 02/07/19, 21:01

    > Good catch. I would prefer to use the use statement like the other > Exceptions. But basically the patch works PHP built-in Exceptions are used the same way in this class (look for \RuntimeException)
  5. Guido Schmechel voted on patch set 1 CR +1 02/07/19, 21:53

  6. deleted-gerrit-51883 voted on patch set 1 V +1 CR +1 02/20/19, 11:19

  7. Markus Klein voted on patch set 1 V +2 CR +2 02/20/19, 12:17

  8. Markus Klein merged patch set 2 02/20/19, 12:17