Review main Merged

59643[BUGFIX] Use proper argument for options in SendEmailCommand

Georg Ringer CR +2 V +2 Easy +4 −4 updated 02/06/19, 23:05

Commit message

InputOption::VALUE_REQUIRED must be used instead of InputArgument::REQUIRED.

Review

  • Code review CR +2
    • Benni Mack +2
    • Josef Glatz +1
    • Oliver Klee +1
  • Verified V +2
    • Markus Klein +2
    • Josef Glatz +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Georg Ringer uploaded patch set 1 02/05/19, 12:10

  2. TYPO3com voted on patch set 1 V +1 02/05/19, 12:28 Completed build in 15m 01s on Tue, 5 Feb, 01:28 PM Test Summary: 46409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32047

  3. Oliver Klee voted on patch set 1 CR +1 02/05/19, 12:38

  4. Benni Mack voted on patch set 1 V +1 CR +2 02/06/19, 07:42

  5. Josef Glatz voted on patch set 1 V +1 CR +1 02/06/19, 13:55

  6. Markus Klein voted on patch set 1 V +2 02/06/19, 23:04

  7. Markus Klein merged patch set 2 02/06/19, 23:04

  8. Markus Klein commented on patch set 2 02/06/19, 23:05

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit 491089ed28c3226d0ad4fdda1f3f05a6b1b3015b