59644[BUGFIX] GifBuilder returns already generated images
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Stephan Großberndt +1
- Guido Schmechel +1
- Wouter Wolters +1
- Ralph Brugger +1
-
Verified V +2 Done
- Benni Mack +2
- Guido Schmechel +1
- Ralph Brugger +1
- TYPO3com +1 CI
Issues 3
Files 3
Review log 3851
Show 1726 earlier messages
-
Markus Klösges uploaded patch set 1 02/05/19, 12:31
-
TYPO3com voted on patch set 1 V -1 02/05/19, 12:31 Completed build in 10s on Tue, 5 Feb, 01:31 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32048
-
Markus Klösges uploaded patch set 2 02/05/19, 12:39
-
TYPO3com voted on patch set 2 V -1 02/05/19, 12:39 Completed build in 10s on Tue, 5 Feb, 01:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32049
-
Markus Klösges rebased onto patch set 3 02/05/19, 12:41
-
TYPO3com commented on patch set 3 02/05/19, 12:41 Completed build in 10s on Tue, 5 Feb, 01:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32050
-
Markus Klösges uploaded patch set 4 02/05/19, 12:41
-
Oliver Klee commented on patch set 4 CR +1 02/05/19, 12:53
Beautiful test!GifBuilder.php:212Any reason to not combine these two unsets into one (with a comma)? -
TYPO3com voted on patch set 4 V -1 02/05/19, 12:56 Completed build in 14m 31s on Tue, 5 Feb, 01:56 PM Test Summary: 2 of 46809 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32051
-
Markus Klösges uploaded patch set 5 02/05/19, 13:37
-
TYPO3com voted on patch set 5 V -1 02/05/19, 13:37 Completed build in 12s on Tue, 5 Feb, 02:37 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32053
-
Markus Klösges uploaded patch set 6 02/05/19, 13:40
-
TYPO3com voted on patch set 6 V +1 02/05/19, 13:56 Completed build in 15m 43s on Tue, 5 Feb, 02:56 PM Test Summary: 46412 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32054
-
Oliver Klee commented on patch set 6 02/05/19, 13:59
GifBuilderTest.php:92Why this check? Why not use assertSame? -
Markus Klösges commented on patch set 6 02/05/19, 14:01
GifBuilderTest.php:92Replymakes sense. Mostly because the driving factor for the hash generation is the serialized form. But assertSame should work out fine. Will push a revision in a sec -
Markus Klösges uploaded patch set 7 02/05/19, 14:02
-
TYPO3com voted on patch set 7 V +1 02/05/19, 14:17 Completed build in 14m 45s on Tue, 5 Feb, 03:17 PM Test Summary: 46412 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32057
-
Oliver Klee voted on patch set 7 CR +1 02/05/19, 19:21
-
Andreas Wolf voted on patch set 7 CR +1 02/05/19, 20:28
-
Georg Ringer commented on patch set 7 02/07/19, 10:45
GifBuilder.php:212i would probose only using 1 unset and both as arguments -
Markus Klösges uploaded patch set 8 02/07/19, 13:33
-
Markus Klösges commented on patch set 8 02/07/19, 13:34
GifBuilder.php:212ReplyDone -
TYPO3com voted on patch set 8 V +1 02/07/19, 13:46 Completed build in 12m 25s on Thu, 7 Feb, 02:46 PM Test Summary: 46394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32100
-
Alexander Schnitzler commented on patch set 8 02/07/19, 15:27
whether -
Markus Klösges updated the commit message in patch set 9 02/07/19, 15:29
-
TYPO3com voted on patch set 9 V +1 02/07/19, 15:46 Completed build in 16m 02s on Thu, 7 Feb, 04:46 PM Test Summary: 46394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32105
-
Georg Ringer voted on patch set 9 V +1 CR +1 02/07/19, 17:16
-
Oliver Klee voted on patch set 9 CR +1 02/07/19, 18:15
-
Ralph Brugger commented on patch set 9 V +1 CR +1 02/15/19, 08:18
Works fine vor us with 8.7.24 -
Anja Leichsenring commented on patch set 10 02/17/19, 09:33
Published edit on patch set 9. -
Anja Leichsenring commented on patch set 10 V -1 02/17/19, 09:35
the test file needs adjustment. It sets up an instance of GifBuilder, then never uses it, but creates two new ones. Also, in test files use new for instance construction, GU::makeInstance. -
TYPO3com voted on patch set 10 V +1 02/17/19, 09:51 Completed build in 16m 10s on Sun, 17 Feb, 10:51 AM Test Summary: 46584 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32250
-
Markus Klösges uploaded patch set 11 02/17/19, 10:29
-
TYPO3com voted on patch set 11 V -1 02/17/19, 10:29 Completed build in 12s on Sun, 17 Feb, 11:29 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32255
-
Markus Klösges commented on patch set 11 02/17/19, 10:30
> the test file needs adjustment. It sets up an instance of GifBuilder, then never uses it, but creates two new ones. Thanks for your comments. I think those are addresed. I wanted to use two different gifbuilder instances on purpose, to catch inconsistencies there, but obviously missed the unused member variable. > Also, in test files use new for instance construction, GU::makeInstance. I wasn't aware of that. TIL -
Markus Klösges uploaded patch set 12 02/17/19, 10:31
-
TYPO3com voted on patch set 12 V +1 02/17/19, 10:44 Completed build in 12m 36s on Sun, 17 Feb, 11:44 AM Test Summary: 46584 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32256
-
Oliver Klee voted on patch set 12 CR +1 02/17/19, 14:33
-
Anja Leichsenring commented on patch set 12 02/19/19, 20:38
> Patch Set 11: > > > the test file needs adjustment. It sets up an instance of GifBuilder, then never uses it, but creates two new ones. > > Thanks for your comments. I think those are addresed. > I wanted to use two different gifbuilder instances on purpose, to catch inconsistencies there, but obviously missed the unused member variable. > > > Also, in test files use new for instance construction, GU::makeInstance. > I wasn't aware of that. TIL all fine, better now. But for cleanliness reasons, please remove the now empty setUp function of the test. Code looks good, will vote once the nit picking is done :) -
Benni Mack commented on patch set 12 02/28/19, 20:42
GifBuilderTest.php:27I think we can skip that setUp() call ;) -
Markus Klösges uploaded patch set 13 03/01/19, 09:22
-
Markus Klösges commented on patch set 13 03/01/19, 09:24
GifBuilderTest.php:27ReplyAck. Sorry for letting that slip through ;-) -
TYPO3com voted on patch set 13 V +1 03/01/19, 09:35 Completed build in 12m 53s on Fri, 1 Mar, 10:35 AM Test Summary: 46584 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32439
-
Oliver Klee voted on patch set 13 CR +1 03/01/19, 13:02
-
Benni Mack voted on patch set 13 CR +1 03/07/19, 15:57
-
Guido Schmechel commented on patch set 13 V +1 CR +1 03/08/19, 05:35
Great respect for the fact that you got the topic done. Successfully verified with the master and example from #86947 -
Wouter Wolters voted on patch set 13 CR +1 03/08/19, 22:19
-
Stephan Großberndt voted on patch set 13 CR +1 03/08/19, 23:11
-
Benni Mack voted on patch set 13 V +2 CR +2 03/09/19, 13:48
-
Benni Mack merged patch set 14 03/09/19, 13:48
-
Ralph Brugger commented on patch set 14 V +1 CR +1 03/09/19, 15:11
Tested