Review main Abandoned

59645[TASK] Update friendsofphp/php-cs-fixer and symfony/console

Alexander Schnitzler CR 0 V 0 Normal +157 −82 updated 02/11/19, 10:14

Commit message

In order to be able to run Build/Scripts/cglFixMyCommit.sh
with PHP 7.3, friendsofphp/php-cs-fixer needs to be updated
to at least 2.14.0.

friendsofphp/php-cs-fixer relies on a newer version of
symfony/console, therefore symfony/console needs to be
updated to at least 4.1.6.

Commands:
- composer update symfony/console --no-dev
- composer update friendsofphp/php-cs-fixer --with-dependencies

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 47

  1. Alexander Schnitzler uploaded patch set 1 02/05/19, 14:27

  2. TYPO3com voted on patch set 1 V -1 02/05/19, 14:40 Completed build in 12m 24s on Tue, 5 Feb, 03:40 PM Test Summary: 46409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32059

  3. Alexander Schnitzler uploaded patch set 2 02/05/19, 15:21

  4. TYPO3com voted on patch set 2 V +1 02/05/19, 15:35 Completed build in 13m 59s on Tue, 5 Feb, 04:35 PM Test Summary: 46409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32060

  5. Alexander Schnitzler updated the commit message in patch set 3 02/05/19, 16:05

  6. TYPO3com voted on patch set 3 V +1 02/05/19, 16:19 Completed build in 14m 31s on Tue, 5 Feb, 05:19 PM Test Summary: 46409 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32061

  7. Alexander Schnitzler abandoned the change 02/11/19, 10:14