Review main Merged

59648[TASK] Migrate Redirect Url Validator into own class

Benni Mack CR +2 V +2 Hard +506 −425 updated 02/06/19, 07:48

Commit message

The logic within EXT:felogin for validating proper redirect/referer
URLs is extracted into a new PHP class, which can now be called
separately.

This is useful for further refactorings within the Controller,
and it lays the foundation to use proper validation in various
places other than Extbase.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Georg Ringer +1
  • Verified V +2
    • Anja Leichsenring +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 57

  1. Benni Mack uploaded patch set 1 02/05/19, 18:50

  2. TYPO3com voted on patch set 1 V +1 02/05/19, 19:05 Completed build in 14m 41s on Tue, 5 Feb, 08:05 PM Test Summary: 46391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32065

  3. Benni Mack uploaded patch set 2 02/06/19, 06:46

  4. TYPO3com voted on patch set 2 V +1 02/06/19, 07:01 Completed build in 14m 52s on Wed, 6 Feb, 08:01 AM Test Summary: 46391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32068

  5. Georg Ringer voted on patch set 2 V +1 CR +1 02/06/19, 07:45

  6. Anja Leichsenring voted on patch set 2 V +2 CR +2 02/06/19, 07:48

  7. Anja Leichsenring merged patch set 3 02/06/19, 07:48