59648[TASK] Migrate Redirect Url Validator into own class
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Georg Ringer +1
-
Verified V +2
- Anja Leichsenring +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/felogin/Classes/Controller/FrontendLoginController.php+20 −101
- typo3/sysext/felogin/Classes/Validation/RedirectUrlValidator.phpnew+131 −0
- typo3/sysext/felogin/Tests/Unit/Controller/FrontendLoginControllerTest.php+30 −324
- typo3/sysext/felogin/Tests/Unit/Validation/RedirectUrlValidatorTest.phpnew+325 −0
Review log 57
-
Benni Mack uploaded patch set 1 02/05/19, 18:50
-
TYPO3com voted on patch set 1 V +1 02/05/19, 19:05 Completed build in 14m 41s on Tue, 5 Feb, 08:05 PM Test Summary: 46391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32065
-
Benni Mack uploaded patch set 2 02/06/19, 06:46
-
TYPO3com voted on patch set 2 V +1 02/06/19, 07:01 Completed build in 14m 52s on Wed, 6 Feb, 08:01 AM Test Summary: 46391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32068
-
Georg Ringer voted on patch set 2 V +1 CR +1 02/06/19, 07:45
-
Anja Leichsenring voted on patch set 2 V +2 CR +2 02/06/19, 07:48
-
Anja Leichsenring merged patch set 3 02/06/19, 07:48