Review main Merged

59649[TASK] Allow strings in site configuration type "select"

Georg Ringer CR +2 V +2 Easy +2 −1 updated 02/08/19, 07:54

Commit message

To allow more usecases for extending the site configuration,
the value of tca type select should only be typecasted
if it looks like an integer.

Review

  • Code review CR +2
    • Benni Mack +2
    • Josef Glatz +1
  • Verified V +2
    • Benni Mack +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Georg Ringer uploaded patch set 1 02/06/19, 07:50

  2. TYPO3com voted on patch set 1 V +1 02/06/19, 08:03 Completed build in 12m 17s on Wed, 6 Feb, 09:03 AM Test Summary: 46391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32071

  3. Benni Mack voted on patch set 1 V +1 CR +1 02/06/19, 08:04

  4. Josef Glatz voted on patch set 1 V +1 CR +1 02/06/19, 13:55

  5. Benni Mack voted on patch set 1 V +2 CR +2 02/08/19, 07:54

  6. Benni Mack merged patch set 2 02/08/19, 07:54

  7. Benni Mack commented on patch set 2 02/08/19, 07:54

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit b15cfcc886b2150a6642cadb86de1a8797059936