Review main Merged

59650[FEATURE] Introduce BitSet class

Alexander Schnitzler CR +2 V +2 Normal +249 −0 updated 02/23/19, 17:01

Commit message

This patch introduces a simple BitSet class that
can be used to handle boolean flags.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1621

  1. Alexander Schnitzler uploaded patch set 1 02/06/19, 10:38

  2. TYPO3com voted on patch set 1 V +1 02/06/19, 10:50 Completed build in 11m 53s on Wed, 6 Feb, 11:50 AM Test Summary: 46411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32076

  3. Alexander Schnitzler uploaded patch set 2 02/06/19, 13:40

  4. TYPO3com voted on patch set 2 V +1 02/06/19, 13:52 Completed build in 11m 26s on Wed, 6 Feb, 02:52 PM Test Summary: 46411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32079

  5. Oliver Klee commented on patch set 2 CR +1 02/06/19, 15:37

    Beautiful!
  6. Stephan Großberndt commented on patch set 2 CR -1 02/06/19, 22:46

    Feature-87665-IntroduceBitSetClass.rst:12

    Introduced instead of introduces
  7. Alexander Schnitzler commented on patch set 3 02/07/19, 08:49

    Published edit on patch set 2.
  8. TYPO3com voted on patch set 3 V +1 02/07/19, 09:07 Completed build in 16m 55s on Thu, 7 Feb, 10:07 AM Test Summary: 46435 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32090

  9. Oliver Klee voted on patch set 3 CR +1 02/09/19, 12:39

  10. Andreas Wolf commented on patch set 3 CR +1 02/10/19, 09:48

    Looks good in general! :)

    BitSet.php:17

    Maybe the namespace should be DataStructures? We might have more of these in the future, and "Bit" is a bit too specific IMO.

    BitSet.php:61

    Not sure if there is a specific vocabulary for bit operations, but "unset" as the antagonist for "set" sounds more logical to me.
  11. Alexander Schnitzler uploaded patch set 4 02/17/19, 11:18

  12. Alexander Schnitzler wrote 02/17/19, 11:19

    Description set to "Changed the namespace part Bit to DataStructure and renamed the clear method to unset."
  13. TYPO3com voted on patch set 4 V +1 02/17/19, 11:31 Completed build in 13m 40s on Sun, 17 Feb, 12:31 PM Test Summary: 46601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32258

  14. Alexander Schnitzler rebased onto patch set 5 02/17/19, 11:38

  15. Alexander Schnitzler wrote 02/17/19, 11:39

    Description set to "Rebase"
  16. TYPO3com voted on patch set 5 V +1 02/17/19, 11:50 Completed build in 11m 49s on Sun, 17 Feb, 12:50 PM Test Summary: 46601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32260

  17. Oliver Klee voted on patch set 5 CR +1 02/17/19, 14:32

  18. Susi Moog voted on patch set 5 V +1 CR +1 02/17/19, 17:28

  19. Andreas Kienast voted on patch set 5 V +1 CR +1 02/18/19, 08:04

  20. Anja Leichsenring voted on patch set 5 V +2 CR +2 02/23/19, 17:01

  21. Anja Leichsenring merged patch set 6 02/23/19, 17:01