Review main Abandoned

59651[FEATURE] Introduce FieldControl for renderType=selectSingle

Kevin Ditscheid CR 0 V 0 Normal +99 −0 updated 01/25/20, 12:04

Commit message

The fieldControl feature from selectMultipleSideBySide is really useful,
therefore this commit introduces it to the renderType selectSingle.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 611

  1. Kevin Ditscheid uploaded patch set 1 02/06/19, 11:10

  2. TYPO3com voted on patch set 1 V -1 02/06/19, 11:24 Completed build in 13m 49s on Wed, 6 Feb, 12:24 PM Test Summary: 46391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32077

  3. Oliver Klee commented on patch set 1 CR -1 02/06/19, 15:39

    Can we have tests for this?

    SelectSingleElement.php:248

    Can we please move this to a well-named protected method instead of moving this already-too-long method even longer?
  4. Susi Moog rebased onto patch set 2 10/25/19, 19:29

  5. TYPO3com voted on patch set 2 V -1 10/25/19, 19:48 Completed build in 14m 09s on Fri, 25 Oct, 07:48 PM Test Summary: 1 of 48418 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37738

  6. TYPO3com commented on patch set 2 11/09/19, 12:03 Completed build in 08m 08s on Sat, 9 Nov, 12:03 PM Test Summary: 47941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38160

  7. TYPO3com commented on patch set 2 11/09/19, 12:22 Completed build in 17h 01m 25s on Sat, 9 Nov, 12:22 PM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37738

  8. Mathias Brodala commented on patch set 3 11/23/19, 21:35

    Published edit on patch set 2.
  9. Mathias Brodala commented on patch set 3 CR -1 11/23/19, 21:36

    Aside from the other comments this needs an RST.
  10. TYPO3com voted on patch set 3 V +1 11/23/19, 21:42 Completed build in 07m 03s on Sat, 23 Nov, 09:42 PM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38788

  11. Susi Moog abandoned the change 01/25/20, 12:04

    Abandoned in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/61566 which already contains an rst file.