Review main Merged

59658[BUGFIX] Revert Set controller in ExtbasePluginEnhancer"

Benni Mack CR +2 V +2 Easy +0 −7 updated 02/07/19, 08:46

Commit message

The accepted change adds an ugly side-effect when using
the same controller/action in multiple route variants.

This reverts commit 977ed578d04a3c2094cdad3207b5d9f86322f326.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 46

  1. Benni Mack uploaded patch set 1 02/07/19, 08:28

  2. Benni Mack updated the commit message in patch set 2 02/07/19, 08:28

  3. TYPO3com voted on patch set 2 V +1 02/07/19, 08:40 Completed build in 12m 21s on Thu, 7 Feb, 09:40 AM Test Summary: 46415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32087

  4. TYPO3com voted on patch set 1 V +1 02/07/19, 08:43 Completed build in 14m 55s on Thu, 7 Feb, 09:43 AM Test Summary: 46415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32086

  5. Oliver Hader voted on patch set 2 V +2 CR +2 02/07/19, 08:45

  6. Oliver Hader merged patch set 3 02/07/19, 08:46