59659[BUGFIX] Set default controller name in ExtbasePluginEnhancer
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Jörg Bösche +1
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 3033
Show 68 earlier messages
-
Oliver Hader uploaded patch set 1 02/07/19, 08:44
-
Oliver Hader commented on patch set 1 02/07/19, 08:49
-
TYPO3com voted on patch set 1 V +1 02/07/19, 09:00 Completed build in 16m 32s on Thu, 7 Feb, 10:00 AM Test Summary: 46415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32088
-
Oliver Hader uploaded patch set 2 02/07/19, 10:41
-
TYPO3com voted on patch set 2 V +1 02/07/19, 10:54 Completed build in 12m 35s on Thu, 7 Feb, 11:54 AM Test Summary: 46406 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32094
-
Guido Schmechel commented on patch set 2 02/07/19, 12:29
Thanks! I will have a look tonight.ExtbasePluginEnhancer.php:170Can safely be removed because default value. Or do you want to keep that for readability reasons? -
Oliver Hader commented on patch set 2 02/07/19, 13:31
ExtbasePluginEnhancer.php:170ReplyYepp, wanted to be explicit here -
Guido Schmechel commented on patch set 2 V -1 02/07/19, 20:55
If i use your code I do not get a correctly generated URL. But I can call the actually correct URL manually. So the code is going in the right direction! I need this extra case in applyControllerActionValues() and furthermore the applyControllerActionValues function inside of the route foreach. (Line 127) What do you think about it?ExtbasePluginEnhancer.php:170ReplyDoneExtbasePluginEnhancer.php:228UnresolvedAnother case for me: } elseif ($tryUpdate && !empty($target['controller']) && $actionName !== ($target['action'] ?? null)) { $target['action'] = $actionName;
-
Oliver Hader commented on patch set 2 02/08/19, 07:11
Hi Guido, can you please add your scenario to the test (even if it temporarily fails)? This way I would have a better understanding what it is about. Thx -
Guido Schmechel commented on patch set 2 02/09/19, 09:26
Hi Oliver! Unfortunately, I do not get this done so quickly with the tests because I'm still pretty new to functional tests. But with XDebug, I've been able to break down the behavior for you, and maybe that will help you with the analysis. More in the ticket as a comment. If you need access to the extension or configuration, please let me know. -
Guido Schmechel commented on patch set 2 02/22/19, 17:10
See also further discussion in forge -
Anja Leichsenring commented on patch set 2 03/01/19, 14:11
so what concludes from the forge discussion? No issue, but documentation flaw? Is the -1 still valid or just a leftover? -
Guido Schmechel commented on patch set 2 03/01/19, 14:21
For me it is still unclear, so still the -1. The question is actually only, if it is a documentation issue, or if we have to intercept something in the code. Maybe I'm too stupid ;-) -
Guido Schmechel commented on patch set 2 03/02/19, 15:51
https://forge.typo3.org/issues/87542 That could also be a relevant topic. -
Alexander Schnitzler wrote 03/21/19, 18:57
Topic set to extbase -
Benni Mack commented on patch set 2 06/14/19, 12:46
what's the status here? -
Anja Leichsenring wrote 09/09/19, 13:35
Removed reviewer Anja Leichsenring. -
Tymoteusz Motylewski commented on patch set 2 09/09/19, 19:53
if not given -
Henning Liebe updated the commit message in patch set 3 10/09/19, 11:50
-
Henning Liebe commented on patch set 3 10/09/19, 11:51
just fixed the commit message -
Henning Liebe commented on patch set 3 10/09/19, 11:52
Reply
Done -
TYPO3com voted on patch set 3 V +1 10/09/19, 12:01 Completed build in 11m 25s on Wed, 9 Oct, 12:01 PM Test Summary: 47734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37176
-
Jörg Bösche commented on patch set 3 CR -1 10/10/19, 07:30
ExtbasePluginEnhancer.php:232UnresolvedCan we eliminate the else case and set it as an default right after the list()? After that, the condition may follow with the tryUpdate and override the controller or action. -
Jörg Bösche commented on patch set 3 CR +1 10/28/19, 07:20
I reviewed my last statement and came to the conclusion that we should not change the implementation. Otherwise, we will override the controller or action if we set some sort of "default" without checks. -
Oliver Hader wrote 11/03/19, 16:15
Topic extbase removed -
Oliver Hader wrote 11/03/19, 16:15
Topic set to routing -
Benni Mack voted on patch set 3 CR +1 11/07/19, 21:37
-
Benni Mack voted on patch set 3 CR +2 11/07/19, 21:37
-
Benni Mack voted on patch set 3 CR +1 11/07/19, 21:48
-
Benni Mack voted on patch set 3 CR +2 11/07/19, 21:50
-
Susi Moog voted on patch set 3 V +1 CR +1 11/09/19, 15:47
-
Benni Mack voted on patch set 3 V +2 11/09/19, 16:22
-
Benni Mack merged patch set 4 11/09/19, 16:22
ExtbasePluginEnhancer.php:205