59662[BUGFIX] Cast fallback language uids to integer
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Georg Ringer +1
- Oliver Klee +1
- Alexander Schnitzler +1
-
Verified V +2
- Markus Klein +2
- Georg Ringer +1
- Alexander Schnitzler +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2329
Show 24 earlier messages
-
Andreas Kienast uploaded patch set 1 02/07/19, 12:11
-
Andreas Kienast updated the commit message in patch set 2 02/07/19, 12:16
-
TYPO3com voted on patch set 1 V +1 02/07/19, 12:26 Completed build in 14m 46s on Thu, 7 Feb, 01:26 PM Test Summary: 46391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32096
-
TYPO3com voted on patch set 2 V +1 02/07/19, 12:29 Completed build in 12m 34s on Thu, 7 Feb, 01:29 PM Test Summary: 46391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32097
-
Fabien Udriot voted on patch set 2 V +1 CR +1 02/07/19, 12:48
-
Mathias Brodala commented on patch set 3 02/07/19, 13:13
Published edit on patch set 2. -
Mathias Brodala commented on patch set 3 02/07/19, 13:13
Slightly rewritten for readability. -
Mathias Brodala commented on patch set 4 02/07/19, 13:26
Published edit on patch set 3. -
Mathias Brodala commented on patch set 4 02/07/19, 13:26
Fixed a small inconsistency. -
TYPO3com voted on patch set 3 V +1 02/07/19, 13:27 Completed build in 13m 41s on Thu, 7 Feb, 02:27 PM Test Summary: 46391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32098
-
TYPO3com voted on patch set 4 V +1 02/07/19, 13:38 Completed build in 11m 56s on Thu, 7 Feb, 02:38 PM Test Summary: 46391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32099
-
Mathias Brodala voted on patch set 4 CR +1 02/07/19, 13:41
-
Markus Klein commented on patch set 4 02/07/19, 15:23
cast - cast - cast irregular ;-) -
Markus Klein updated the commit message in patch set 5 02/07/19, 15:23
-
Markus Klein voted on patch set 5 CR +1 02/07/19, 15:24
-
Alexander Schnitzler voted on patch set 5 CR +1 02/07/19, 15:24
-
Mathias Brodala voted on patch set 5 CR +1 02/07/19, 15:29
-
Georg Ringer commented on patch set 5 CR -2 02/07/19, 15:30
Got a test pending and will push at night -
TYPO3com voted on patch set 5 V +1 02/07/19, 15:40 Completed build in 16m 02s on Thu, 7 Feb, 04:39 PM Test Summary: 46391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32103
-
Georg Ringer uploaded patch set 6 02/07/19, 17:15
-
Georg Ringer voted on patch set 6 V +1 CR +1 02/07/19, 17:16
-
TYPO3com voted on patch set 6 V +1 02/07/19, 17:28 Completed build in 12m 53s on Thu, 7 Feb, 06:28 PM Test Summary: 46391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32107
-
Oliver Klee commented on patch set 6 02/07/19, 17:31
SiteLanguage.php:158Why not use GeneralUtility::intExplode? -
Andreas Kienast commented on patch set 6 02/07/19, 17:34
SiteLanguage.php:158ReplyThat doesn't help if $fallbackLanguageIds is already an array, that is still mixed ;) -
Oliver Klee voted on patch set 6 CR +1 02/07/19, 18:03
-
Alexander Schnitzler voted on patch set 6 V +1 CR +1 02/07/19, 20:14
-
Markus Klein voted on patch set 6 V +2 CR +2 02/07/19, 23:36
-
Markus Klein merged patch set 7 02/07/19, 23:36
-
Markus Klein commented on patch set 7 02/07/19, 23:36
Cherry Picked This patchset was cherry picked to branch 9.5 as commit 58600393db264cd878613b631354270a2dd3e6b2