Review main Merged

59668[TASK] Update doctrine/dbal to ~2.8.0

Andreas Kienast CR +2 V +2 Expert +1295 −432 updated 02/09/19, 12:38

Commit message

doctrine/dbal 2.7.x will reach end of life before core
v9 is out of support. We should upgrade to at least 2.8:

composer req doctrine/dbal:~2.8.0

https://www.doctrine-project.org/2018/07/12/common-2-9-and-dbal-2-8-and-orm-2-6-2.html

Also needs a typo3/testing-framework raise:

composer req --dev typo3/testing-framework:~5.0.5

Needed core changes:
- DBAL does not add "OFFSET 0" if nothing given (test change only)
- SQLite does not need "PRIMARY KEY" if autoincrement is given (in DefaultTcaSchema)

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1625

  1. Andreas Kienast uploaded patch set 1 02/08/19, 11:14

  2. TYPO3com voted on patch set 1 V -1 02/08/19, 11:15 Completed build in 06s on Fri, 8 Feb, 12:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32114

  3. Andreas Kienast uploaded patch set 2 02/08/19, 11:17

  4. TYPO3com voted on patch set 2 V -1 02/08/19, 11:29 Completed build in 11m 58s on Fri, 8 Feb, 12:29 PM Test Summary: 578 of 27546 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32115

  5. Christian Kuhn uploaded patch set 3 02/08/19, 12:06

  6. TYPO3com voted on patch set 3 V -1 02/08/19, 12:19 Completed build in 12m 20s on Fri, 8 Feb, 01:19 PM Test Summary: 578 of 46734 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32116

  7. Christian Kuhn uploaded patch set 4 02/08/19, 14:10

  8. TYPO3com voted on patch set 4 V +1 02/08/19, 14:22 Completed build in 12m 35s on Fri, 8 Feb, 03:22 PM Test Summary: 46397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32119

  9. Christian Kuhn uploaded patch set 5 02/08/19, 15:12

  10. Christian Kuhn uploaded patch set 6 02/08/19, 15:24

  11. Christian Kuhn updated the commit message in patch set 7 02/08/19, 15:24

  12. TYPO3com voted on patch set 5 V -1 02/08/19, 15:26 Completed build in 13m 11s on Fri, 8 Feb, 04:26 PM Test Summary: 46397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32122

  13. TYPO3com voted on patch set 7 V +1 02/08/19, 15:38 Completed build in 13m 47s on Fri, 8 Feb, 04:38 PM Test Summary: 46397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32124

  14. TYPO3com voted on patch set 6 V +1 02/08/19, 15:39 Completed build in 14m 37s on Fri, 8 Feb, 04:39 PM Test Summary: 46397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32123

  15. Christian Kuhn voted on patch set 7 V +1 CR +1 02/08/19, 15:41

  16. Benni Mack commented on patch set 7 02/08/19, 20:23

    Nice. Have you tried 2.9.0 as well? Could this work as well?
  17. Anja Leichsenring updated the commit message in patch set 8 02/09/19, 11:01

  18. TYPO3com voted on patch set 8 V +1 02/09/19, 11:15 Completed build in 13m 09s on Sat, 9 Feb, 12:15 PM Test Summary: 46397 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32128

  19. Andreas Kienast voted on patch set 8 V +1 CR +1 02/09/19, 11:31

  20. Anja Leichsenring commented on patch set 8 CR -1 02/09/19, 11:31

    we have no sqlite tests on TcaSchema anymore. Let me push one.
  21. Anja Leichsenring uploaded patch set 9 02/09/19, 11:34

  22. TYPO3com voted on patch set 9 V +1 02/09/19, 11:47 Completed build in 13m 01s on Sat, 9 Feb, 12:47 PM Test Summary: 46561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32129

  23. Andreas Kienast voted on patch set 9 V +1 CR +1 02/09/19, 12:36

  24. Anja Leichsenring voted on patch set 9 V +2 CR +2 02/09/19, 12:38

  25. Anja Leichsenring merged patch set 10 02/09/19, 12:38