Review main Merged

59681[TASK] Missing quote in declaring the task example

TYPO3com CR +2 V +2 Easy +1 −1 updated 02/16/19, 11:06

Commit message

The current declaring a task example produces a PHP syntax error because
of a missing quote

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Guido Schmechel +1
    • Jörg Bösche +1
  • Verified V +2
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. TYPO3com uploaded patch set 1 02/11/19, 14:31

  2. TYPO3com voted on patch set 1 V +1 02/11/19, 14:51 Completed build in 16m 19s on Mon, 11 Feb, 03:51 PM Test Summary: 46561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32142

  3. Oliver Klee commented on patch set 1 02/11/19, 15:27

    Are 9.5 and 8.7 affected as well?
  4. Getdesigned GmbH commented on patch set 1 02/11/19, 16:10

    Reply

    No, only master is affected, 9.5 and 8.7 are using the variable $_EXTKEY in the example
  5. Oliver Klee voted on patch set 1 CR +1 02/11/19, 16:28

  6. Jörg Bösche voted on patch set 1 CR +1 02/14/19, 14:49

  7. Guido Schmechel voted on patch set 1 CR +1 02/16/19, 10:43

  8. Anja Leichsenring voted on patch set 1 V +2 CR +2 02/16/19, 11:06

  9. Anja Leichsenring merged patch set 2 02/16/19, 11:06