Review main Merged

59682[BUGFIX] Cast lastMod property to int

Richard Haeser CR +2 V +2 Easy +2 −2 updated 02/13/19, 07:20

Commit message

To prevent type mismatches when using pdo_mysql as the database driver,
the data for the lastMod field is cast to an integer.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Josef Glatz +1
    • Oliver Klee +1
    • Björn Jacob +1
    • Guido Schmechel +1
    • Jörg Bösche +1
    • André Buchmann +1
  • Verified V +2
    • Georg Ringer +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1215

  1. Richard Haeser uploaded patch set 1 02/11/19, 19:25

  2. Oliver Klee updated the commit message in patch set 2 02/11/19, 19:25

  3. Oliver Klee commented on patch set 3 02/11/19, 19:26

    Published edit on patch set 2.
  4. Oliver Klee voted on patch set 3 CR +1 02/11/19, 19:27

  5. TYPO3com voted on patch set 2 V +1 02/11/19, 19:39 Completed build in 13m 15s on Mon, 11 Feb, 08:39 PM Test Summary: 46561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32149

  6. TYPO3com voted on patch set 1 V +1 02/11/19, 19:40 Completed build in 15m 12s on Mon, 11 Feb, 08:40 PM Test Summary: 46561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32148

  7. TYPO3com voted on patch set 3 V +1 02/11/19, 19:42 Completed build in 10m 56s on Mon, 11 Feb, 08:42 PM Test Summary: 46561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32150

  8. Björn Jacob voted on patch set 3 CR +1 02/12/19, 21:29

  9. Guido Schmechel voted on patch set 3 CR +1 02/12/19, 21:49

  10. André Buchmann voted on patch set 3 CR +1 02/12/19, 22:30

  11. Jörg Bösche voted on patch set 3 CR +1 02/12/19, 22:57

  12. Josef Glatz voted on patch set 3 V +1 CR +1 02/13/19, 04:42

  13. Georg Ringer voted on patch set 3 V +2 CR +2 02/13/19, 07:19

  14. Georg Ringer merged patch set 4 02/13/19, 07:19

  15. Georg Ringer commented on patch set 4 02/13/19, 07:20

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit ce2dc6ab460173b67430983df885e5446dfe272b