Review main Merged

59683[TASK] Allow type 'check' in site configuration

Julian Wundrak CR +2 V +2 Easy +4 −0 updated 02/14/19, 12:36

Commit message

Add check option to site-config tca for something like active or
maintenance mode
Resolves: #87692
Releases: master, 9.5
Change-Id: Idaa09a5929db5bdf177e57c5f78f827047705f91
Reviewed-on: https://review.typo3.org/59683
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: André Schließer <andy.schliesser@gmail.com>
Tested-by: André Schließer <andy.schliesser@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>

Review

  • Code review CR +2
    • Georg Ringer +2
    • Daniel Goerz +1
    • Jörg Bösche +1
    • André Buchmann +1
  • Verified V +2
    • Georg Ringer +2
    • André Buchmann +1
    • TYPO3com +1 CI

Files 1

Review log 1013

  1. Julian Wundrak uploaded patch set 1 02/11/19, 20:43

  2. Julian Wundrak updated the commit message in patch set 2 02/11/19, 20:46

  3. TYPO3com voted on patch set 1 V +1 02/11/19, 20:57 Completed build in 13m 50s on Mon, 11 Feb, 09:57 PM Test Summary: 46561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32153

  4. TYPO3com voted on patch set 2 V +1 02/11/19, 21:00 Completed build in 13m 51s on Mon, 11 Feb, 10:00 PM Test Summary: 46561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32154

  5. Georg Ringer updated the commit message in patch set 3 02/12/19, 06:58

  6. TYPO3com voted on patch set 3 V +1 02/12/19, 07:11 Completed build in 13m 05s on Tue, 12 Feb, 08:11 AM Test Summary: 46561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32157

  7. Daniel Goerz voted on patch set 3 CR +1 02/12/19, 09:52

  8. André Buchmann voted on patch set 3 V +1 CR +1 02/12/19, 23:10

  9. Jörg Bösche voted on patch set 3 CR +1 02/13/19, 09:44

  10. Georg Ringer voted on patch set 3 V +1 CR +1 02/14/19, 12:31

  11. Georg Ringer voted on patch set 3 V +2 CR +2 02/14/19, 12:35

  12. Georg Ringer merged patch set 4 02/14/19, 12:35

  13. Georg Ringer commented on patch set 4 02/14/19, 12:36

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit 84978ae2406308b97a2de8af3bb70de3e13a4630