Review main Merged

59685[BUGFIX] Simplify if in typolink

Stefan Froemken CR +2 V +2 Easy +1 −1 updated 02/12/19, 15:56

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Pascal Rinker +1
  • Verified V +2
    • Benni Mack +2
    • Pascal Rinker +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Stefan Froemken uploaded patch set 1 02/12/19, 15:30

  2. Pascal Rinker commented on patch set 1 V +1 CR +1 02/12/19, 15:33

    You´re right. The removed part of that if seems to be redundant. Isset should never return null.
  3. TYPO3com voted on patch set 1 V +1 02/12/19, 15:44 Completed build in 13m 46s on Tue, 12 Feb, 04:44 PM Test Summary: 46561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32164

  4. Benni Mack voted on patch set 1 V +2 CR +2 02/12/19, 15:56

  5. Benni Mack merged patch set 2 02/12/19, 15:56