Review main Merged

59688[BUGFIX] Add missing interface to AdminPanel Cache Module

Frank Nägler CR +2 V +2 Easy +14 −1 updated 02/13/19, 09:19

Commit message

The AdminPanel Cache Module has to implement the
ResourceProviderInterface to load the required JavaScript module.

Review

  • Code review CR +2
    • Markus Klein +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2
    • Markus Klein +2
    • Andreas Kienast +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Frank Nägler uploaded patch set 1 02/13/19, 08:32

  2. Andreas Kienast commented on patch set 1 V +1 CR +1 02/13/19, 08:33

    I had the same result and it worked
  3. TYPO3com voted on patch set 1 V +1 02/13/19, 08:45 Completed build in 12m 40s on Wed, 13 Feb, 09:45 AM Test Summary: 46561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32172

  4. Markus Klein updated the commit message in patch set 2 02/13/19, 08:46

  5. Markus Klein voted on patch set 2 V +1 CR +1 02/13/19, 08:47

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 02/13/19, 08:49

  7. TYPO3com voted on patch set 2 V +1 02/13/19, 09:01 Completed build in 14m 26s on Wed, 13 Feb, 10:01 AM Test Summary: 46561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32173

  8. Benni Mack voted on patch set 2 V +1 CR +1 02/13/19, 09:06

  9. Markus Klein voted on patch set 2 V +2 CR +2 02/13/19, 09:18

  10. Markus Klein merged patch set 3 02/13/19, 09:18

  11. Markus Klein commented on patch set 3 02/13/19, 09:19

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit bbcdc2cf83a942f67de9197e74598bc1c9fc39e3