Review main Merged

59708[BUGFIX] EXT:opendocs - Remove bogus initial document count

Andreas Kienast CR +2 V +2 Easy +2 −4 updated 02/16/19, 11:20

Commit message

When the opendocs toolbar item gets initialized, the document count shows
a bogus value as deleted records are not removed from the calculation.

As the documents are loaded deferred since #84412, the correct value gets
in place automatically which renders the initial counting obsolete and is
removed with this patch.

Additonally, a wrong class hint in OpenDocumentController is fixed.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Georg Ringer +1
    • Björn Jacob +1
    • Anja Leichsenring +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Georg Ringer +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 78

  1. Andreas Kienast uploaded patch set 1 02/15/19, 16:19

  2. TYPO3com voted on patch set 1 V +1 02/15/19, 16:32 Completed build in 12m 56s on Fri, 15 Feb, 05:32 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32239

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 02/15/19, 16:34

  4. Georg Ringer voted on patch set 1 V +1 CR +1 02/16/19, 06:23

  5. Björn Jacob voted on patch set 1 CR +1 02/16/19, 07:17

  6. Tymoteusz Motylewski voted on patch set 1 V +2 CR +2 02/16/19, 09:12

  7. Tymoteusz Motylewski merged patch set 2 02/16/19, 09:12

  8. Anja Leichsenring commented on patch set 2 02/16/19, 11:20

    Cherry Picked This patchset was cherry picked to branch 9.5 as commit 64e463ac38bf1a796639dec7a0a633ba6d63e711