Review main Merged

59714[FEATURE] Enable validation of password via hooks during password changes

Sascha Grötzner CR +2 V +2 Normal +72 −25 updated 02/23/19, 19:12

Commit message

changes

Add a new $_param variable "passwordValid" and
"passwordInvalidMessage" process via Hook.
In the Hook to can do your own validation or other stuff and
set "passwordValid" to false an generate a Message to
"passwordInvalidMessage".
If $hookPasswordValid is false then the password is not set
in DB and the script runs its normal way. (it will redirect
to the PasswordChange Form an prints the
"passwordInvalidMessage")

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 913

  1. Sascha Grötzner uploaded patch set 1 02/17/19, 11:07

  2. TYPO3com voted on patch set 1 V -1 02/17/19, 11:07 Completed build in 10s on Sun, 17 Feb, 12:07 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32257

  3. Guido Schmechel commented on patch set 1 02/17/19, 11:28

    First of all: Thanks for your contribution! :-) To get rid of -1. Please run cglFixCommit:https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Appendix/CglFixMyCommit.html#cgl-fix-my-commit Btw: Features are only allowed for the master. So please adjust your commit message
  4. Sascha Grötzner uploaded patch set 2 02/17/19, 11:51

  5. TYPO3com voted on patch set 2 V +1 02/17/19, 12:04 Completed build in 12m 41s on Sun, 17 Feb, 01:04 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32261

  6. Alexander Schnitzler commented on patch set 2 CR -1 02/17/19, 12:54

    Besides my comments, this patch looks good (good wise).

    Unresolved

    The message could be a bit more verbose. Something like: - Let hooks validate new passwords during password changes - Enable validation of passwords via hooks during password changes

    Unresolved

    and

    Unresolved

    runs

    FrontendLoginController.php:376 Unresolved

    Please add a trailing comma here. This will leave this line untouched in future patches that add more params.

    FrontendLoginController.php:386 Unresolved

    The default value should be declared before the if block. The else block can be removed then. This reduces complexity.

    FrontendLoginController.php:390

    I really don't like adding another nested condition here but given the surrounding code I see no other choice than to do it this way. However, this method is a perfect candidate for a refactoring with early returns to reduce complexity and possible paths.
  7. Sascha Grötzner uploaded patch set 3 02/17/19, 13:27

  8. Sascha Grötzner uploaded patch set 4 02/17/19, 13:30

  9. TYPO3com voted on patch set 3 V +1 02/17/19, 13:39 Completed build in 11m 21s on Sun, 17 Feb, 02:39 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32262

  10. TYPO3com voted on patch set 4 V +1 02/17/19, 13:44 Completed build in 13m 48s on Sun, 17 Feb, 02:44 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32263

  11. Susi Moog voted on patch set 4 V +1 CR +1 02/23/19, 18:24

  12. Anja Leichsenring voted on patch set 4 V +2 CR +2 02/23/19, 19:12

  13. Anja Leichsenring merged patch set 5 02/23/19, 19:12