Review main Merged

59719[BUGFIX] Don't call mergeRecursiveWithOverrule with null argument

Alexander Schnitzler CR +2 V +2 Easy +44 −4 updated 02/23/19, 17:50

Commit message

During the removal of deprecated code in Extbase, a bug has been
introduced which is fixed with this patch.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 912

  1. Alexander Schnitzler uploaded patch set 1 02/18/19, 14:05

  2. Alexander Schnitzler updated the commit message in patch set 2 02/18/19, 14:09

  3. TYPO3com voted on patch set 1 V +1 02/18/19, 14:19 Completed build in 14m 28s on Mon, 18 Feb, 03:19 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32283

  4. TYPO3com voted on patch set 2 V +1 02/18/19, 14:21 Completed build in 12m 02s on Mon, 18 Feb, 03:21 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32284

  5. Susi Moog voted on patch set 2 CR +1 02/18/19, 15:10

  6. Oliver Klee commented on patch set 2 02/18/19, 18:03

    If this has gone unnoticed, would it make sense to cover this with tests to make sure it keeps working?
  7. Alexander Schnitzler commented on patch set 2 02/18/19, 22:08

    > Patch Set 2: > > If this has gone unnoticed, would it make sense to cover this with tests to make sure it keeps working? Yes! Absolutely. Unfortunately I don’t habe any time myself. Would love to see this taken care od by others.
  8. Susi Moog uploaded patch set 3 02/23/19, 17:09

  9. Susi Moog voted on patch set 3 V +1 CR +1 02/23/19, 17:12

  10. TYPO3com voted on patch set 3 V +1 02/23/19, 17:49 Completed build in 35m 45s on Sat, 23 Feb, 06:49 PM Test Summary: 46609 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32354

  11. Anja Leichsenring voted on patch set 3 V +2 CR +2 02/23/19, 17:50

  12. Anja Leichsenring merged patch set 4 02/23/19, 17:50