Review main Merged

59755[TASK] Mock FileRepository Singletons in unit tests

Benjamin Franzke CR +2 V +2 Easy +43 −1 updated 02/23/19, 17:18

Commit message

Prevent indirect SignalSlot\Dispatcher and ObjectManager
invocation by mocking FileRepository.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 78

  1. Benjamin Franzke uploaded patch set 1 02/19/19, 11:28

  2. TYPO3com voted on patch set 1 V +1 02/19/19, 11:43 Completed build in 14m 46s on Tue, 19 Feb, 12:43 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32295

  3. Oliver Klee commented on patch set 1 02/19/19, 11:51

    TcaSelectItemsTest.php:1691

    Do we already have a ::purgeInstances call in tearDown to avoid effects on other tests?
  4. Benjamin Franzke commented on patch set 1 02/19/19, 12:32

    TcaSelectItemsTest.php:1691 Reply

    yes, it's already there.
  5. Susi Moog voted on patch set 1 CR +1 02/23/19, 14:48

  6. Susi Moog voted on patch set 1 V +1 02/23/19, 17:17

  7. Anja Leichsenring voted on patch set 1 V +2 CR +2 02/23/19, 17:18

  8. Anja Leichsenring merged patch set 2 02/23/19, 17:18