59758[TASK] Replace calls to assertAttribute* methods of phpunit
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Daniel Goerz +1
- Susi Moog +1
-
Verified V +2 Done
- Georg Ringer +2
- Daniel Goerz +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 13
- typo3/sysext/belog/Tests/Unit/Domain/Model/ConstraintTest.php+4 −8
- typo3/sysext/core/Tests/Unit/Log/Fixtures/WriterFixture.php+5 −0
- typo3/sysext/core/Tests/Unit/Log/Processor/AbstractMemoryTest.php+2 −22
- typo3/sysext/core/Tests/Unit/Log/Writer/FileWriterTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Log/LoggerTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Mail/MailerTest.php5+16 −2
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/PersistenceManagerTest.php+57 −12
- typo3/sysext/extbase/Tests/UnitDeprecated/Reflection/ObjectAccessTest.php+0 −18
- typo3/sysext/fluid/Tests/Unit/Core/Rendering/RenderingContextTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/Core/Widget/WidgetContextTest.php+2 −1
- typo3/sysext/fluid/Tests/Unit/View/TemplatePathsTest.php+2 −1
- typo3/sysext/frontend/Tests/Unit/Authentication/FrontendUserAuthenticationTest.php+5 −5
Review log 1419
-
Anja Leichsenring uploaded patch set 1 02/19/19, 19:42
-
TYPO3com voted on patch set 1 V -1 02/19/19, 19:43 Completed build in 10s on Tue, 19 Feb, 08:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32304
-
Anja Leichsenring uploaded patch set 2 02/19/19, 19:44
-
Anja Leichsenring commented on patch set 2 02/19/19, 19:44
no backport proposed on intention, stable branches need their own review. -
TYPO3com voted on patch set 2 V +1 02/19/19, 19:57 Completed build in 12m 47s on Tue, 19 Feb, 08:57 PM Test Summary: 46569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32305
-
Susi Moog commented on patch set 2 CR -1 02/23/19, 15:13
MailerTest.php:65what is asserted now?MailerTest.php:77same as above - what is asserted? (the test case name is not reflected by the test I think) -
Anja Leichsenring commented on patch set 2 02/23/19, 15:16
MailerTest.php:65Replylook line 61 - the line ensures the ->get Method gets called with the $settings and is not touched by the $GLOBALS stuff.MailerTest.php:77Reply Unresolvedhere, $settings actually IS the $GLOBALS stuff and ->get (line 76) gets called with this parameter. -
Susi Moog commented on patch set 2 02/23/19, 15:17
MailerTest.php:65Reply Unresolvedcan you move that to a shouldHaveBeenCalled thingy? for me the willReturn part is basically test setup not assertion. -
Anja Leichsenring uploaded patch set 3 02/23/19, 15:26
-
TYPO3com voted on patch set 3 V -1 02/23/19, 15:26 Completed build in 14s on Sat, 23 Feb, 04:26 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32343
-
Anja Leichsenring uploaded patch set 4 02/23/19, 15:30
-
TYPO3com voted on patch set 4 V +1 02/23/19, 15:41 Completed build in 10m 43s on Sat, 23 Feb, 04:41 PM Test Summary: 46569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32344
-
Susi Moog voted on patch set 4 V +1 CR +1 02/23/19, 16:44
-
Anja Leichsenring uploaded patch set 5 02/23/19, 18:04
-
Susi Moog voted on patch set 5 V +1 CR +1 02/23/19, 18:26
-
TYPO3com voted on patch set 5 V +1 02/23/19, 19:07 Completed build in 39m 40s on Sat, 23 Feb, 08:07 PM Test Summary: 46593 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32363
-
Daniel Goerz voted on patch set 5 V +1 CR +1 02/23/19, 20:26
-
Georg Ringer voted on patch set 5 V +2 CR +2 02/23/19, 20:30
-
Georg Ringer merged patch set 6 02/23/19, 20:30