Review main Merged

59758[TASK] Replace calls to assertAttribute* methods of phpunit

Anja Leichsenring CR +2 V +2 Normal +104 −80 updated 02/23/19, 20:30

Commit message

Those methods are about to be removed, in preparation the core tests
were reviewed for usage and replaced with suitable functionality.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Daniel Goerz +1
    • Susi Moog +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Daniel Goerz +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 13

Review log 1419

  1. Anja Leichsenring uploaded patch set 1 02/19/19, 19:42

  2. TYPO3com voted on patch set 1 V -1 02/19/19, 19:43 Completed build in 10s on Tue, 19 Feb, 08:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32304

  3. Anja Leichsenring uploaded patch set 2 02/19/19, 19:44

  4. Anja Leichsenring commented on patch set 2 02/19/19, 19:44

    no backport proposed on intention, stable branches need their own review.
  5. TYPO3com voted on patch set 2 V +1 02/19/19, 19:57 Completed build in 12m 47s on Tue, 19 Feb, 08:57 PM Test Summary: 46569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32305

  6. Susi Moog commented on patch set 2 CR -1 02/23/19, 15:13

    MailerTest.php:65

    what is asserted now?

    MailerTest.php:77

    same as above - what is asserted? (the test case name is not reflected by the test I think)
  7. Anja Leichsenring commented on patch set 2 02/23/19, 15:16

    MailerTest.php:65 Reply

    look line 61 - the line ensures the ->get Method gets called with the $settings and is not touched by the $GLOBALS stuff.

    MailerTest.php:77 Reply Unresolved

    here, $settings actually IS the $GLOBALS stuff and ->get (line 76) gets called with this parameter.
  8. Susi Moog commented on patch set 2 02/23/19, 15:17

    MailerTest.php:65 Reply Unresolved

    can you move that to a shouldHaveBeenCalled thingy? for me the willReturn part is basically test setup not assertion.
  9. Anja Leichsenring uploaded patch set 3 02/23/19, 15:26

  10. TYPO3com voted on patch set 3 V -1 02/23/19, 15:26 Completed build in 14s on Sat, 23 Feb, 04:26 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32343

  11. Anja Leichsenring uploaded patch set 4 02/23/19, 15:30

  12. TYPO3com voted on patch set 4 V +1 02/23/19, 15:41 Completed build in 10m 43s on Sat, 23 Feb, 04:41 PM Test Summary: 46569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32344

  13. Susi Moog voted on patch set 4 V +1 CR +1 02/23/19, 16:44

  14. Anja Leichsenring uploaded patch set 5 02/23/19, 18:04

  15. Susi Moog voted on patch set 5 V +1 CR +1 02/23/19, 18:26

  16. TYPO3com voted on patch set 5 V +1 02/23/19, 19:07 Completed build in 39m 40s on Sat, 23 Feb, 08:07 PM Test Summary: 46593 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32363

  17. Daniel Goerz voted on patch set 5 V +1 CR +1 02/23/19, 20:26

  18. Georg Ringer voted on patch set 5 V +2 CR +2 02/23/19, 20:30

  19. Georg Ringer merged patch set 6 02/23/19, 20:30