Review main Abandoned

59763[WIP][TASK] Replace exceptions with argument types

Georg Ringer CR 0 V 0 Normal +38 −97 updated 01/08/20, 20:12

Commit message

Review

  • Code review CR 0
  • Verified V 0

Files 21

Review log 46

  1. Georg Ringer uploaded patch set 1 02/20/19, 12:20

  2. TYPO3com voted on patch set 1 V -1 02/20/19, 12:29 Completed build in 05m 03s on Wed, 20 Feb, 01:29 PM Test Summary: 67 of 214 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32313

  3. Georg Ringer uploaded patch set 2 02/20/19, 12:31

  4. TYPO3com voted on patch set 2 V -1 02/20/19, 12:44 Completed build in 12m 50s on Wed, 20 Feb, 01:44 PM Test Summary: 1340 of 46918 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32314

  5. Alexander Schnitzler commented on patch set 2 03/17/19, 20:04

    Just one thing already. I'd consider this change breaking as TypeErrors are now thrown instead of former Exceptions. I'd recommend adding a breaking rst file for all api methods and adding them to the scanner.
  6. Georg Ringer abandoned the change 01/08/20, 20:12