59763[WIP][TASK] Replace exceptions with argument types
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 21
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+1 −5
- typo3/sysext/core/Classes/Cache/Backend/AbstractBackend.php+3 −3
- typo3/sysext/core/Classes/Category/CategoryRegistry.php+5 −5
- typo3/sysext/core/Classes/Http/UploadedFile.php+2 −5
- typo3/sysext/core/Classes/Http/Uri.php+2 −6
- typo3/sysext/core/Classes/Resource/Index/Indexer.php+2 −2
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+2 −2
- typo3/sysext/core/Classes/Utility/ArrayUtility.php+1 −4
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+1 −13
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+1 −4
- typo3/sysext/core/Classes/Utility/VersionNumberUtility.php+1 −4
- typo3/sysext/extbase/Classes/Mvc/Controller/Argument.php+1 −4
- typo3/sysext/extbase/Classes/Mvc/Web/Response.php+1 −4
- typo3/sysext/extbase/Classes/Mvc/Request.php+4 −9
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+2 −2
- typo3/sysext/extbase/Classes/Property/PropertyMapper.php+1 −5
- typo3/sysext/extensionmanager/Classes/Domain/Model/DownloadQueue.php+2 −2
- typo3/sysext/form/Classes/Domain/Model/FormElements/UnknownFormElement.php+2 −2
- typo3/sysext/form/Classes/Domain/Model/FormDefinition.php+2 −2
- typo3/sysext/frontend/Classes/ContentObject/Menu/MenuContentObjectFactory.php+1 −7
Show 1 more file
Review log 46
-
Georg Ringer uploaded patch set 1 02/20/19, 12:20
-
TYPO3com voted on patch set 1 V -1 02/20/19, 12:29 Completed build in 05m 03s on Wed, 20 Feb, 01:29 PM Test Summary: 67 of 214 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32313
-
Georg Ringer uploaded patch set 2 02/20/19, 12:31
-
TYPO3com voted on patch set 2 V -1 02/20/19, 12:44 Completed build in 12m 50s on Wed, 20 Feb, 01:44 PM Test Summary: 1340 of 46918 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32314
-
Alexander Schnitzler commented on patch set 2 03/17/19, 20:04
Just one thing already. I'd consider this change breaking as TypeErrors are now thrown instead of former Exceptions. I'd recommend adding a breaking rst file for all api methods and adding them to the scanner. -
Georg Ringer abandoned the change 01/08/20, 20:12