Review main Merged

59773[FEATURE] Add seo fields to info module

Georg Ringer CR +2 V +2 Normal +51 −3 updated 02/19/20, 10:56

Commit message

The options "SEO" and "Social Media" are added to the Pagetree Overview.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Simon Gilli +1
    • Christian Eßl +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Christian Eßl +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1319

  1. Georg Ringer uploaded patch set 1 02/20/19, 22:02

  2. TYPO3com voted on patch set 1 V -1 02/20/19, 22:03 Completed build in 12s on Wed, 20 Feb, 11:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32322

  3. Josef Glatz commented on patch set 1 02/21/19, 05:57

    I'm experimenting also with some different fieldDefinitions for the module in my TYPO3 Distribution the last couple of months: https://github.com/josefglatz/TYPO3-Distribution/blob/f72c1acfa173030aa4281cc77d905573c5b81f74/app/web/typo3conf/ext/theme/Configuration/TsConfig/Page/General/PagetreeOverview.tsconfig.typoscript Depending on the different fields, a column needs often an alternative label which describes it better in the Info Modul submodule. Beside the purpose oft this patch: I think the module itself needs some adoptions to make it more useful.
  4. Kevin Appelt uploaded patch set 2 02/18/20, 21:46

  5. TYPO3com voted on patch set 2 V +1 02/18/20, 22:04 Completed build in 17m 34s on Tue, 18 Feb, 10:04 PM Test Summary: 71342 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-274

  6. Kevin Appelt uploaded patch set 3 02/18/20, 22:14

  7. Kevin Appelt updated the commit message in patch set 4 02/18/20, 22:18

  8. Kevin Appelt commented on patch set 4 02/18/20, 22:29

    Lets see if we can remove the "WIP" by replying.
  9. TYPO3com voted on patch set 3 V +1 02/18/20, 22:37 Completed build in 17m 36s on Tue, 18 Feb, 10:37 PM Test Summary: 71344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-278

  10. Kevin Appelt uploaded patch set 5 02/18/20, 22:39

  11. TYPO3com voted on patch set 4 V +1 02/18/20, 22:44 Completed build in 24m 02s on Tue, 18 Feb, 10:44 PM Test Summary: 71344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-279

  12. Simon Gilli voted on patch set 5 CR +1 02/18/20, 22:46

  13. Benni Mack commented on patch set 5 02/18/20, 22:54

    This change is ready for review.
  14. TYPO3com voted on patch set 5 V -1 02/18/20, 23:12 Completed build in 29m 52s on Tue, 18 Feb, 11:12 PM Test Summary: 1 of 71801 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-282

  15. TYPO3com voted on patch set 5 V +1 02/18/20, 23:46 Completed build in 26m 47s on Tue, 18 Feb, 11:46 PM Test Summary: 71344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-284

  16. Daniel Goerz voted on patch set 5 V +1 CR +1 02/19/20, 09:16

  17. Christian Eßl voted on patch set 5 V +1 CR +1 02/19/20, 10:45

  18. Daniel Goerz voted on patch set 5 V +2 CR +2 02/19/20, 10:56

  19. Daniel Goerz merged patch set 6 02/19/20, 10:56