Review main Merged

59774[BUGFIX] Do not render unused attribute in Checkbox element

Benni Mack CR +2 V +2 Easy +1 −1 updated 02/21/19, 10:45

Commit message

Due to refactoring in FormEngine back in 2015, the Checkbox
Element renders " ... 1 ... " when a checkbox element is not
disabled.

To overcome this, the ternary operator is turned around,
returning an empty string when the element is not disabled.

Review

  • Code review CR +2 Done
    • Markus Klein +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Markus Klein +2
    • Georg Ringer +1
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Benni Mack uploaded patch set 1 02/20/19, 22:54

  2. TYPO3com voted on patch set 1 V +1 02/20/19, 23:08 Completed build in 13m 20s on Thu, 21 Feb, 12:08 AM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32323

  3. Georg Ringer voted on patch set 1 V +1 CR +1 02/21/19, 07:08

  4. Mathias Brodala voted on patch set 1 CR +1 02/21/19, 08:16

  5. Mathias Brodala voted on patch set 1 V +1 02/21/19, 08:17

  6. Wouter Wolters voted on patch set 1 CR +1 02/21/19, 09:38

  7. Markus Klein voted on patch set 1 V +2 CR +2 02/21/19, 10:45

  8. Markus Klein merged patch set 2 02/21/19, 10:45