Review 9.5 Merged

59778[BUGFIX] Do not render unused attribute in Checkbox element

Markus Klein CR +2 V +2 Easy +1 −1 updated 02/21/19, 15:52

Commit message

Due to refactoring in FormEngine back in 2015, the Checkbox
Element renders " ... 1 ... " when a checkbox element is not
disabled.

To overcome this, the ternary operator is turned around,
returning an empty string when the element is not disabled.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Markus Klein commented on patch set 1 02/21/19, 10:47

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 02/21/19, 11:05 Completed build in 13m 31s on Thu, 21 Feb, 12:05 PM Test Summary: 49309 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-260

  3. Oliver Klee voted on patch set 1 CR +1 02/21/19, 13:07

  4. Benni Mack voted on patch set 1 V +2 CR +2 02/21/19, 15:52

  5. Benni Mack merged patch set 2 02/21/19, 15:52