Review main Merged

59781[TASK] Do not instantiate DocumentTemplate at every BE call

Benni Mack CR +2 V +2 Easy +32 −5 updated 02/23/19, 16:29

Commit message

Currently, document template and thus, pagerenderer is initialized
with all functionality and loaded CSS for every BE call,
which is unnecessary for simple JSON-based AJAX calls.

In order to avoid this, PageRenderer is now instantiated only
when needed - when ModuleTemplate or DocumentTemplate
are initialized, resulting in higher performance for AJAX calls
but also removing a necessary means for having DocumentTemplate
set up at all BE requests, reducing the need for DocTemplate
even more, so it can slowly be migrated to ModuleTemplate
in the future.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Susi Moog +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 810

  1. Benni Mack uploaded patch set 1 02/21/19, 16:08

  2. TYPO3com voted on patch set 1 V -1 02/21/19, 16:08 Completed build in 14s on Thu, 21 Feb, 05:08 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32333

  3. Benni Mack uploaded patch set 2 02/21/19, 16:44

  4. TYPO3com voted on patch set 2 V +1 02/21/19, 16:55 Completed build in 11m 44s on Thu, 21 Feb, 05:55 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32335

  5. Georg Ringer voted on patch set 2 V +1 CR +1 02/21/19, 19:55

  6. Susi Moog voted on patch set 2 CR +1 02/23/19, 14:38

  7. Anja Leichsenring voted on patch set 2 V +1 CR +1 02/23/19, 16:18

  8. Susi Moog voted on patch set 2 V +1 02/23/19, 16:27

  9. Anja Leichsenring voted on patch set 2 V +2 CR +2 02/23/19, 16:29

  10. Anja Leichsenring merged patch set 3 02/23/19, 16:29