Review TYPO3_8-7 Merged

59783[BUGFIX] Only apply hidden restriction for table sys_language

Manuel Selbach CR +2 V +2 Easy +4 −5 updated 02/24/19, 11:04

Commit message

Previously the HiddenRestriction::class applied the hidden restriction
to both tables, with this change only the hidden field of sys_language
will be checked, which was also the case before the DBAL migration.

Review

  • Code review CR +2 Done
    • Markus Klein +2
    • Claus Due +1
    • Joerg Kummer +1
  • Verified V +2 Done
    • Markus Klein +2
    • Joerg Kummer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 811

  1. Manuel Selbach uploaded patch set 1 02/21/19, 21:06

  2. TYPO3com voted on patch set 1 V -1 02/21/19, 21:07 Completed build in 10s on Thu, 21 Feb, 10:07 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3415

  3. Manuel Selbach uploaded patch set 2 02/21/19, 21:13

  4. Claus Due updated the commit message in patch set 3 02/21/19, 21:17

  5. Claus Due commented on patch set 3 CR +1 02/21/19, 21:19

    Use case discussed in a lot of detail after encountering this in the wild. Should hopefully be all clear why we need to specifically condition only `s.hidden` field instead of using HiddenRestriction.
  6. TYPO3com voted on patch set 2 V +1 02/21/19, 21:35 Completed build in 20m 48s on Thu, 21 Feb, 10:34 PM Test Summary: 79524 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3416

  7. TYPO3com voted on patch set 3 V +1 02/21/19, 21:35 Completed build in 16m 55s on Thu, 21 Feb, 10:34 PM Test Summary: 79524 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3417

  8. Markus Klein voted on patch set 3 CR +1 02/21/19, 22:44

  9. Joerg Kummer commented on patch set 3 V +1 CR +1 02/23/19, 12:58

    Tested and compared with v7.6
  10. Markus Klein voted on patch set 3 V +2 CR +2 02/24/19, 11:04

  11. Markus Klein merged patch set 4 02/24/19, 11:04